* [PATCH?] atl1e: WAKE_MCAST 2x. 1st WAKE_UCAST?
@ 2008-08-07 16:24 roel kluin
2008-08-08 1:25 ` Jie Yang
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: roel kluin @ 2008-08-07 16:24 UTC (permalink / raw)
To: jie.yang, jgarzik; +Cc: netdev, linux-kernel
untested, is it right?
---
WAKE_MCAST bit tested twice, test WAKE_UCAST first.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
diff --git a/drivers/net/atl1e/atl1e_ethtool.c b/drivers/net/atl1e/atl1e_ethtool.c
index cdc3b85..619c658 100644
--- a/drivers/net/atl1e/atl1e_ethtool.c
+++ b/drivers/net/atl1e/atl1e_ethtool.c
@@ -355,7 +355,7 @@ static int atl1e_set_wol(struct net_device *netdev, struct ethtool_wolinfo *wol)
struct atl1e_adapter *adapter = netdev_priv(netdev);
if (wol->wolopts & (WAKE_ARP | WAKE_MAGICSECURE |
- WAKE_MCAST | WAKE_BCAST | WAKE_MCAST))
+ WAKE_UCAST | WAKE_MCAST | WAKE_BCAST))
return -EOPNOTSUPP;
/* these settings will always override what we currently have */
adapter->wol = 0;
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [PATCH?] atl1e: WAKE_MCAST 2x. 1st WAKE_UCAST?
2008-08-07 16:24 [PATCH?] atl1e: WAKE_MCAST 2x. 1st WAKE_UCAST? roel kluin
@ 2008-08-08 1:25 ` Jie Yang
2008-08-08 3:12 ` Jie Yang
2008-08-14 8:44 ` Jeff Garzik
2 siblings, 0 replies; 4+ messages in thread
From: Jie Yang @ 2008-08-08 1:25 UTC (permalink / raw)
To: roel kluin, jgarzik@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
On Friday, August 08, 2008 12:25 AM
roel kluin <roel.kluin@gmail.com> wrote:
> untested, is it right?
> ---
> WAKE_MCAST bit tested twice, test WAKE_UCAST first.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com> diff --git
> a/drivers/net/atl1e/atl1e_ethtool.c
> b/drivers/net/atl1e/atl1e_ethtool.c
> index cdc3b85..619c658 100644
> --- a/drivers/net/atl1e/atl1e_ethtool.c
> +++ b/drivers/net/atl1e/atl1e_ethtool.c
> @@ -355,7 +355,7 @@ static int atl1e_set_wol(struct
> net_device *netdev, struct ethtool_wolinfo *wol)
> struct atl1e_adapter *adapter = netdev_priv(netdev);
>
> if (wol->wolopts & (WAKE_ARP | WAKE_MAGICSECURE |
> - WAKE_MCAST | WAKE_BCAST | WAKE_MCAST))
> + WAKE_UCAST | WAKE_MCAST | WAKE_BCAST))
> return -EOPNOTSUPP;
> /* these settings will always override what we
> currently have */
> adapter->wol = 0;
>
Yes, It should be this! Thanks!
Best wishes
jie
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH?] atl1e: WAKE_MCAST 2x. 1st WAKE_UCAST?
2008-08-07 16:24 [PATCH?] atl1e: WAKE_MCAST 2x. 1st WAKE_UCAST? roel kluin
2008-08-08 1:25 ` Jie Yang
@ 2008-08-08 3:12 ` Jie Yang
2008-08-14 8:44 ` Jeff Garzik
2 siblings, 0 replies; 4+ messages in thread
From: Jie Yang @ 2008-08-08 3:12 UTC (permalink / raw)
To: roel kluin, jgarzik@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
jeff@garzik.org, jacliburn@bellsouth.net
On Friday, August 08, 2008 12:25 AM
roel kluin <roel.kluin@gmail.com> wrote
>
> untested, is it right?
> ---
> WAKE_MCAST bit tested twice, test WAKE_UCAST first.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com> diff --git
> a/drivers/net/atl1e/atl1e_ethtool.c
> b/drivers/net/atl1e/atl1e_ethtool.c
> index cdc3b85..619c658 100644
> --- a/drivers/net/atl1e/atl1e_ethtool.c
> +++ b/drivers/net/atl1e/atl1e_ethtool.c
> @@ -355,7 +355,7 @@ static int atl1e_set_wol(struct
> net_device *netdev, struct ethtool_wolinfo *wol)
> struct atl1e_adapter *adapter = netdev_priv(netdev);
>
> if (wol->wolopts & (WAKE_ARP | WAKE_MAGICSECURE |
> - WAKE_MCAST | WAKE_BCAST | WAKE_MCAST))
> + WAKE_UCAST | WAKE_MCAST | WAKE_BCAST))
> return -EOPNOTSUPP;
> /* these settings will always override what we
> currently have */
> adapter->wol = 0;
>
Yes, it should be this, thanks!
Acked-by: Jie Yang <jie.yang@atheros.com>
BTW: resend on the comments from Jay Cliburn <jacliburn@bellsouth.net>
Thanks Jay
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH?] atl1e: WAKE_MCAST 2x. 1st WAKE_UCAST?
2008-08-07 16:24 [PATCH?] atl1e: WAKE_MCAST 2x. 1st WAKE_UCAST? roel kluin
2008-08-08 1:25 ` Jie Yang
2008-08-08 3:12 ` Jie Yang
@ 2008-08-14 8:44 ` Jeff Garzik
2 siblings, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2008-08-14 8:44 UTC (permalink / raw)
To: roel kluin; +Cc: jie.yang, jgarzik, netdev, linux-kernel
roel kluin wrote:
> untested, is it right?
> ---
> WAKE_MCAST bit tested twice, test WAKE_UCAST first.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> diff --git a/drivers/net/atl1e/atl1e_ethtool.c b/drivers/net/atl1e/atl1e_ethtool.c
> index cdc3b85..619c658 100644
> --- a/drivers/net/atl1e/atl1e_ethtool.c
> +++ b/drivers/net/atl1e/atl1e_ethtool.c
> @@ -355,7 +355,7 @@ static int atl1e_set_wol(struct net_device *netdev, struct ethtool_wolinfo *wol)
> struct atl1e_adapter *adapter = netdev_priv(netdev);
>
> if (wol->wolopts & (WAKE_ARP | WAKE_MAGICSECURE |
> - WAKE_MCAST | WAKE_BCAST | WAKE_MCAST))
> + WAKE_UCAST | WAKE_MCAST | WAKE_BCAST))
> return -EOPNOTSUPP;
> /* these settings will always override what we currently have */
applied
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-08-14 8:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-07 16:24 [PATCH?] atl1e: WAKE_MCAST 2x. 1st WAKE_UCAST? roel kluin
2008-08-08 1:25 ` Jie Yang
2008-08-08 3:12 ` Jie Yang
2008-08-14 8:44 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).