From: Jeff Garzik <jgarzik@pobox.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: Jie Yang <jie.yang@atheros.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [2.6 patch] uninline atl1e_setup_mac_ctrl()
Date: Thu, 14 Aug 2008 04:45:30 -0400 [thread overview]
Message-ID: <48A3F0AA.3080806@pobox.com> (raw)
In-Reply-To: <20080808183334.GZ14495@cs181140183.pp.htv.fi>
Adrian Bunk wrote:
> There doesn't seem to be a compelling reason why atl1e_setup_mac_ctrl()
> is marked as "inline":
>
> It's not used in any place where speed would matter much, and as long as
> it has only one caller non-ancient gcc versions anyway inline it
> automatically.
>
> This patch fixes the following compile error with gcc 3.4:
>
> <-- snip -->
>
> ...
> CC drivers/net/atl1e/atl1e_main.o
> atl1e_main.c: In function `atl1e_check_link':
> atl1e_main.c:50: sorry, unimplemented: inlining failed in call to
> atl1e_main.c:196: sorry, unimplemented: called from here
> make[4]: *** [drivers/net/atl1e/atl1e_main.o] Error 1
>
> <-- snip -->
>
> Reported-by: Adrian Bunk <bunk@kernel.org>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
applied
prev parent reply other threads:[~2008-08-14 8:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-08 18:33 [2.6 patch] uninline atl1e_setup_mac_ctrl() Adrian Bunk
2008-08-14 8:45 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A3F0AA.3080806@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@linux-foundation.org \
--cc=bunk@kernel.org \
--cc=jie.yang@atheros.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).