From: Brian Haley <brian.haley@hp.com>
To: "Denis V. Lunev" <den@parallels.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, containers <containers@lists.osdl.org>
Subject: Re: [PATCH 1/2] netns: fix NULL-dereference in dev_net()
Date: Thu, 14 Aug 2008 16:29:13 -0400 [thread overview]
Message-ID: <48A49599.40307@hp.com> (raw)
In-Reply-To: <1218745207.16589.77.camel@iris.sw.ru>
Denis V. Lunev wrote:
> On Thu, 2008-08-14 at 15:27 -0400, Brian Haley wrote:
>> Change dev_net() to handle a NULL argument - return &init_net instead.
>>
>> -Brian
>>
>> Signed-off-by: Brian Haley <brian.haley@hp.com>
>> ---
>>
> the code is designed keeping in mind that there are no checks for
> net != NULL
> in any place. They are too expensive. We need to invent other way :(
Ok, I'll fix the other callers to pass *net, I was just trying to be
overly safe in dev_net() to avoid a crash.
-Brian
next prev parent reply other threads:[~2008-08-14 20:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-14 19:27 [PATCH 1/2] netns: fix NULL-dereference in dev_net() Brian Haley
2008-08-14 19:55 ` [Devel] " Alexey Dobriyan
2008-08-14 20:01 ` Brian Haley
2008-08-14 20:20 ` Denis V. Lunev
2008-08-14 20:29 ` Brian Haley [this message]
2008-08-16 21:30 ` Daniel Lezcano
2008-08-17 22:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A49599.40307@hp.com \
--to=brian.haley@hp.com \
--cc=containers@lists.osdl.org \
--cc=davem@davemloft.net \
--cc=den@parallels.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).