From: Patrick McHardy <kaber@trash.net>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, jarkao2@gmail.com
Subject: Re: [PATCH 8/9]: sch_hfsc: Use ->requeue queue instead of ops.
Date: Tue, 19 Aug 2008 15:07:10 +0200 [thread overview]
Message-ID: <48AAC57E.1090504@trash.net> (raw)
In-Reply-To: <20080818.222917.10471071.davem@davemloft.net>
David Miller wrote:
> From: Patrick McHardy <kaber@trash.net>
> Date: Mon, 18 Aug 2008 16:11:57 +0200
>
>> I think we really need either ->requeue or a real ->peek operation.
>
> All the code duplication and complexity is what I'm trying to avoid.
>
> I see no value in overhauling and auditing all of these ->requeue()
> implementations and how they return status codes when the facility
> itself is largely superfluous.
>
> Maybe we can simply add a "bool peek" argument or some flags to
> ->dequeue() instead.
Yes, that should work. It might get a big ugly though since the
->dequeue functions have to make sure not to modify any state
while peeking.
next prev parent reply other threads:[~2008-08-19 13:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-18 8:37 [PATCH 8/9]: sch_hfsc: Use ->requeue queue instead of ops David Miller
2008-08-18 14:11 ` Patrick McHardy
2008-08-19 5:29 ` David Miller
2008-08-19 13:03 ` Herbert Xu
2008-08-19 13:07 ` Patrick McHardy [this message]
2008-08-20 22:09 ` Jarek Poplawski
2008-08-20 22:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48AAC57E.1090504@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).