From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Haley Subject: Re: [PATCH RFC 08/24] IPVS: Make protocol handler functions support IPv6 Date: Thu, 21 Aug 2008 11:12:12 -0400 Message-ID: <48AD85CC.8000102@hp.com> References: <1219248931-15064-1-git-send-email-juliusv@google.com> <1219248931-15064-9-git-send-email-juliusv@google.com> <48AD6DBB.9030607@hp.com> <48AD76DE.4030000@hp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, lvs-devel@vger.kernel.org, horms@verge.net.au, kaber@trash.net, vbusam@google.com To: Julius Volz Return-path: In-Reply-To: Sender: lvs-devel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Julius Volz wrote: > Still, I think my original interpretation was correct? It's always > used with constant values and there are many usages similar to this: > > skb->protocol = __constant_htons(ETH_P_802_3); > > Someone feel free to correct me. I know it's a minor point, but look at tcp_ipv6.c: if (skb->protocol == htons(ETH_P_IP)) return tcp_v4_conn_request(sk, skb); That's different from the code you quoted that's doing an assignment. __constant_htons() isn't used anywhere in an if() statement, although I did find a couple in the bonding driver that should be fixed. -Brian