[PATCH 2.6.27-rc1] smc91x.c smc_drv_remove bugfix? (been there a while!)

[PATCH 2.6.27-rc1] smc91x.c smc_drv_remove bugfix? (been there a while!)

[Jonathan Cameron]

From: Jonathan Cameron

Trivial bug fix for typo in smc91x.c that results in null pointer dereference

Signed-of-by: Jonathan Cameron

--
Could just have submitted this as a bug report, but as it's a trivial patch
this seemed easier. Clearly this will be irrelevant if people have moved board
configs to using resource names, but for now... Not been involved with net drivers
before so sorry if I've sent it to the wrong people!

/drivers/net/smc91x.c	2008-07-31 12:02:47.000000000 +0100
+++ b/drivers/net/smc91x.c	2008-07-31 20:06:19.000000000 +0100
@@ -2255,7 +2255,7 @@ static int smc_drv_remove(struct platfor
 
 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "smc91x-regs");
 	if (!res)
-		platform_get_resource(pdev, IORESOURCE_MEM, 0);
+		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	release_mem_region(res->start, SMC_IO_EXTENT);
 
 	free_netdev(ndev);

Re: [PATCH 2.6.27-rc1] smc91x.c smc_drv_remove bug

[Jonathan Cameron]

Dear All,

Guessing Nicolas is away at the mo (or this one passed him by).
Would be good to get this trivial bug fix sorted out.

Thanks,

--
Jonathan Cameron
> From: Jonathan Cameron
> 
> Trivial bug fix for typo in smc91x.c that results in null pointer dereference
> 
> Signed-of-by: Jonathan Cameron
> 
> --
> Could just have submitted this as a bug report, but as it's a trivial patch
> this seemed easier. Clearly this will be irrelevant if people have moved board
> configs to using resource names, but for now... Not been involved with net drivers
> before so sorry if I've sent it to the wrong people!
> 
> /drivers/net/smc91x.c	2008-07-31 12:02:47.000000000 +0100
> +++ b/drivers/net/smc91x.c	2008-07-31 20:06:19.000000000 +0100
> @@ -2255,7 +2255,7 @@ static int smc_drv_remove(struct platfor
>  
>  	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "smc91x-regs");
>  	if (!res)
> -		platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	release_mem_region(res->start, SMC_IO_EXTENT);
>  
>  	free_netdev(ndev);
> 
> 

[PATCH 2.6.27-rc4] smc91x bug fix to avoid null pointer dereference

[Jonathan Cameron]

From: Jonathan Cameron

Bug fix for typo in smc91x.c that results in null pointer dereference.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Acked-by: Nicolas Pitre <nico@cam.org>

--
Rebased against 2.6.27-rc4 and with Nicolas' ack.

--- a/drivers/net/smc91x.c	2008-08-21 14:49:28.000000000 +0100
+++ b/drivers/net/smc91x.c	2008-08-21 15:12:48.000000000 +0100
@@ -2255,7 +2255,7 @@ static int smc_drv_remove(struct platfor
 
 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "smc91x-regs");
 	if (!res)
-		platform_get_resource(pdev, IORESOURCE_MEM, 0);
+		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	release_mem_region(res->start, SMC_IO_EXTENT);
 
 	free_netdev(ndev);