From: Jeff Garzik <jeff@garzik.org>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: "David Miller" <davem@davemloft.net>,
netdev@vger.kernel.org,
"Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>,
"Alistair John Strachan" <alistair@devzero.co.uk>,
"Timothy J Fontaine" <tjfontaine@atxconsulting.com>,
"Edward Hsu" <edward_hsu@realtek.com.tw>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Ivan Vecera" <ivecera@redhat.com>
Subject: Re: [PATCH resend 1/1] r8169: balance pci_map / pci_unmap pair
Date: Wed, 27 Aug 2008 05:18:27 -0400 [thread overview]
Message-ID: <48B51BE3.6010606@garzik.org> (raw)
In-Reply-To: <20080826195606.GA31263@electric-eye.fr.zoreil.com>
Francois Romieu wrote:
> The leak hurts with swiotlb and jumbo frames.
>
> Fix http://bugzilla.kernel.org/show_bug.cgi?id=9468.
>
> Heavily hinted by Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>.
>
> Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
> Tested-by: Alistair John Strachan <alistair@devzero.co.uk>
> Tested-by: Timothy J Fontaine <tjfontaine@atxconsulting.com>
> Cc: Edward Hsu <edward_hsu@realtek.com.tw>
> ---
> drivers/net/r8169.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
> index a3e3895..0f6f974 100644
> --- a/drivers/net/r8169.c
> +++ b/drivers/net/r8169.c
> @@ -2792,7 +2792,7 @@ static int rtl8169_rx_interrupt(struct net_device *dev,
> pkt_size, PCI_DMA_FROMDEVICE);
> rtl8169_mark_to_asic(desc, tp->rx_buf_sz);
> } else {
> - pci_unmap_single(pdev, addr, pkt_size,
> + pci_unmap_single(pdev, addr, tp->rx_buf_sz,
> PCI_DMA_FROMDEVICE);
applied
prev parent reply other threads:[~2008-08-27 9:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-26 19:56 [PATCH resend 1/1] r8169: balance pci_map / pci_unmap pair Francois Romieu
2008-08-27 9:18 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48B51BE3.6010606@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=alistair@devzero.co.uk \
--cc=davem@davemloft.net \
--cc=edward_hsu@realtek.com.tw \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=ivecera@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=tjfontaine@atxconsulting.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).