From: Jeff Garzik <jgarzik@pobox.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>,
rdunlap@xenotime.net, toralf.foerster@gmx.de,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: build issue #564 for v2.6.27-rc4 : undefined reference to `NS8390p_init'
Date: Wed, 27 Aug 2008 05:19:21 -0400 [thread overview]
Message-ID: <48B51C19.9050800@pobox.com> (raw)
In-Reply-To: <20080822192415.1984d1c2@lxorguk.ukuu.org.uk>
Alan Cox wrote:
>> For the record, and from memory, there were three patches.
>
> I would go take a look at the archive if I was you: there were bits from
> Ingo and others too.
>
> The diff you are looking for however appears to be this, which reverts part
> of the follow on patches to the correct original. I shall however refrain
> from looking smug because while the original wd patch was right I'm also the
> idiot who put the bug back into the tree.
>
> Signed-off-by: Alan 'pass the paper bags' Cox <alan@redhat.com>
>
> --- drivers/net/wd.c~ 2008-08-22 19:17:01.000000000 +0100
> +++ drivers/net/wd.c 2008-08-22 19:17:01.000000000 +0100
> @@ -337,7 +337,7 @@
> #ifdef CONFIG_NET_POLL_CONTROLLER
> dev->poll_controller = ei_poll;
> #endif
> - NS8390p_init(dev, 0);
> + NS8390_init(dev, 0);
>
> #if 1
applied
prev parent reply other threads:[~2008-08-27 9:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-22 8:33 build issue #564 for v2.6.27-rc4 : undefined reference to `NS8390p_init' Toralf Förster
2008-08-22 17:26 ` Randy.Dunlap
2008-08-22 17:12 ` Alan Cox
2008-08-22 18:09 ` Andrew Morton
2008-08-22 18:24 ` Alan Cox
2008-08-27 9:19 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48B51C19.9050800@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=toralf.foerster@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).