From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: build issue #564 for v2.6.27-rc4 : undefined reference to `NS8390p_init' Date: Wed, 27 Aug 2008 05:19:21 -0400 Message-ID: <48B51C19.9050800@pobox.com> References: <200808221033.46997.toralf.foerster@gmx.de> <20080822181234.2f33e993@lxorguk.ukuu.org.uk> <20080822110902.432dd99e.akpm@linux-foundation.org> <20080822192415.1984d1c2@lxorguk.ukuu.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Andrew Morton , rdunlap@xenotime.net, toralf.foerster@gmx.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org To: Alan Cox Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:45270 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753830AbYH0JTg (ORCPT ); Wed, 27 Aug 2008 05:19:36 -0400 In-Reply-To: <20080822192415.1984d1c2@lxorguk.ukuu.org.uk> Sender: netdev-owner@vger.kernel.org List-ID: Alan Cox wrote: >> For the record, and from memory, there were three patches. > > I would go take a look at the archive if I was you: there were bits from > Ingo and others too. > > The diff you are looking for however appears to be this, which reverts part > of the follow on patches to the correct original. I shall however refrain > from looking smug because while the original wd patch was right I'm also the > idiot who put the bug back into the tree. > > Signed-off-by: Alan 'pass the paper bags' Cox > > --- drivers/net/wd.c~ 2008-08-22 19:17:01.000000000 +0100 > +++ drivers/net/wd.c 2008-08-22 19:17:01.000000000 +0100 > @@ -337,7 +337,7 @@ > #ifdef CONFIG_NET_POLL_CONTROLLER > dev->poll_controller = ei_poll; > #endif > - NS8390p_init(dev, 0); > + NS8390_init(dev, 0); > > #if 1 applied