From: Jeff Garzik <jgarzik@pobox.com>
To: Ursula Braun <ursula.braun@de.ibm.com>
Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org,
"Klaus-D. Wacker" <kdwacker@de.ibm.com>
Subject: Re: [patch 4/4] LCS recovery dumps when cable reconnect
Date: Wed, 27 Aug 2008 05:19:32 -0400 [thread overview]
Message-ID: <48B51C24.8050400@pobox.com> (raw)
In-Reply-To: <20080821151654.326848000@linux.vnet.ibm.com>
Ursula Braun wrote:
> From: Klaus-D. Wacker <kdwacker@de.ibm.com>
>
> LCS recovery dumps in irq routine when CCW address in
> Subchannel Status Word (SCSW) is zero. This occurs
> when recovery is driven after cable reconnect.
>
> Signed-off-by: Klaus-D. Wacker <kdwacker@de.ibm.com>
> Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
> ---
>
> drivers/s390/net/lcs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff -urpN linux-2.6/drivers/s390/net/lcs.c linux-2.6-patched/drivers/s390/net/lcs.c
> --- linux-2.6/drivers/s390/net/lcs.c 2008-08-20 15:54:46.000000000 +0200
> +++ linux-2.6-patched/drivers/s390/net/lcs.c 2008-08-20 15:55:15.000000000 +0200
> @@ -1412,7 +1412,8 @@ lcs_irq(struct ccw_device *cdev, unsigne
> }
> /* How far in the ccw chain have we processed? */
> if ((channel->state != LCS_CH_STATE_INIT) &&
> - (irb->scsw.cmd.fctl & SCSW_FCTL_START_FUNC)) {
> + (irb->scsw.cmd.fctl & SCSW_FCTL_START_FUNC) &&
> + (irb->scsw.cmd.cpa != 0)) {
> index = (struct ccw1 *) __va((addr_t) irb->scsw.cmd.cpa)
applied 1-4
prev parent reply other threads:[~2008-08-27 9:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 15:10 [patch 0/4] s390: ctcm / lcs / claw fixes for 2.6.27 Ursula Braun
2008-08-21 15:10 ` [patch 1/4] claw: fix memory leak in claw_probe Ursula Braun
2008-08-21 15:10 ` [patch 2/4] claw: netdev->priv vs. netdev->ml_priv Ursula Braun
2008-08-21 15:10 ` [patch 3/4] ctcm: " Ursula Braun
2008-08-21 15:10 ` [patch 4/4] LCS recovery dumps when cable reconnect Ursula Braun
2008-08-27 9:19 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48B51C24.8050400@pobox.com \
--to=jgarzik@pobox.com \
--cc=kdwacker@de.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ursula.braun@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).