netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Cc: Jie Yang <jie.yang@atheros.com>, Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] atl1e: multistatement if missing braces
Date: Wed, 27 Aug 2008 05:37:24 -0400	[thread overview]
Message-ID: <48B52054.1000204@garzik.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0808191029460.4551@wrl-59.cs.helsinki.fi>

Ilpo Järvinen wrote:
> Doesn't cause problems (yet) because err gets zeroed earlier.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
> ---
>  drivers/net/atl1e/atl1e_main.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/atl1e/atl1e_main.c b/drivers/net/atl1e/atl1e_main.c
> index 82d7be1..7685b99 100644
> --- a/drivers/net/atl1e/atl1e_main.c
> +++ b/drivers/net/atl1e/atl1e_main.c
> @@ -2232,10 +2232,11 @@ static int atl1e_resume(struct pci_dev *pdev)
>  
>  	AT_WRITE_REG(&adapter->hw, REG_WOL_CTRL, 0);
>  
> -	if (netif_running(netdev))
> +	if (netif_running(netdev)) {
>  		err = atl1e_request_irq(adapter);
>  		if (err)
>  			return err;
> +	}

applied



      reply	other threads:[~2008-08-27  9:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-19  7:32 [PATCH] atl1e: multistatement if missing braces Ilpo Järvinen
2008-08-27  9:37 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48B52054.1000204@garzik.org \
    --to=jeff@garzik.org \
    --cc=ilpo.jarvinen@helsinki.fi \
    --cc=jie.yang@atheros.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).