* [PATCH] atl1e: multistatement if missing braces
@ 2008-08-19 7:32 Ilpo Järvinen
2008-08-27 9:37 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Ilpo Järvinen @ 2008-08-19 7:32 UTC (permalink / raw)
To: Jie Yang, Jeff Garzik; +Cc: Netdev
[-- Attachment #1: Type: TEXT/PLAIN, Size: 698 bytes --]
Doesn't cause problems (yet) because err gets zeroed earlier.
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
---
drivers/net/atl1e/atl1e_main.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/atl1e/atl1e_main.c b/drivers/net/atl1e/atl1e_main.c
index 82d7be1..7685b99 100644
--- a/drivers/net/atl1e/atl1e_main.c
+++ b/drivers/net/atl1e/atl1e_main.c
@@ -2232,10 +2232,11 @@ static int atl1e_resume(struct pci_dev *pdev)
AT_WRITE_REG(&adapter->hw, REG_WOL_CTRL, 0);
- if (netif_running(netdev))
+ if (netif_running(netdev)) {
err = atl1e_request_irq(adapter);
if (err)
return err;
+ }
atl1e_reset_hw(&adapter->hw);
--
1.5.2.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] atl1e: multistatement if missing braces
2008-08-19 7:32 [PATCH] atl1e: multistatement if missing braces Ilpo Järvinen
@ 2008-08-27 9:37 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-08-27 9:37 UTC (permalink / raw)
To: Ilpo Järvinen; +Cc: Jie Yang, Netdev
Ilpo Järvinen wrote:
> Doesn't cause problems (yet) because err gets zeroed earlier.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
> ---
> drivers/net/atl1e/atl1e_main.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/atl1e/atl1e_main.c b/drivers/net/atl1e/atl1e_main.c
> index 82d7be1..7685b99 100644
> --- a/drivers/net/atl1e/atl1e_main.c
> +++ b/drivers/net/atl1e/atl1e_main.c
> @@ -2232,10 +2232,11 @@ static int atl1e_resume(struct pci_dev *pdev)
>
> AT_WRITE_REG(&adapter->hw, REG_WOL_CTRL, 0);
>
> - if (netif_running(netdev))
> + if (netif_running(netdev)) {
> err = atl1e_request_irq(adapter);
> if (err)
> return err;
> + }
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-08-27 9:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-19 7:32 [PATCH] atl1e: multistatement if missing braces Ilpo Järvinen
2008-08-27 9:37 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).