* [PATCH 1/1] NET: e100, fix iomap read
@ 2008-08-14 16:27 Jiri Slaby
2008-08-14 16:29 ` Brandeburg, Jesse
2008-08-27 9:56 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: Jiri Slaby @ 2008-08-14 16:27 UTC (permalink / raw)
To: jgarzik
Cc: e1000-devel, netdev, linux-kernel, Jiri Slaby, Jeff Kirsher,
Jesse Brandeburg, Bruce Allan, PJ Waskiewicz, John Ronciak
There were 2 omitted readb's used on an iomap space. eliminate them
by using ioread8 instead.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: Bruce Allan <bruce.w.allan@intel.com>
Cc: PJ Waskiewicz <peter.p.waskiewicz.jr@intel.com>
Cc: John Ronciak <john.ronciak@intel.com>
---
drivers/net/e100.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/e100.c b/drivers/net/e100.c
index 7fee644..d7711d8 100644
--- a/drivers/net/e100.c
+++ b/drivers/net/e100.c
@@ -1727,7 +1727,7 @@ static int e100_rx_indicate(struct nic *nic, struct rx *rx,
if ((le16_to_cpu(rfd->command) & cb_el) &&
(RU_RUNNING == nic->ru_running))
- if (readb(&nic->csr->scb.status) & rus_no_res)
+ if (ioread8(&nic->csr->scb.status) & rus_no_res)
nic->ru_running = RU_SUSPENDED;
return -ENODATA;
}
@@ -1750,7 +1750,7 @@ static int e100_rx_indicate(struct nic *nic, struct rx *rx,
if ((le16_to_cpu(rfd->command) & cb_el) &&
(RU_RUNNING == nic->ru_running)) {
- if (readb(&nic->csr->scb.status) & rus_no_res)
+ if (ioread8(&nic->csr->scb.status) & rus_no_res)
nic->ru_running = RU_SUSPENDED;
}
--
1.5.6.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH 1/1] NET: e100, fix iomap read
2008-08-14 16:27 [PATCH 1/1] NET: e100, fix iomap read Jiri Slaby
@ 2008-08-14 16:29 ` Brandeburg, Jesse
2008-08-27 9:56 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Brandeburg, Jesse @ 2008-08-14 16:29 UTC (permalink / raw)
To: Jiri Slaby, jgarzik
Cc: e1000-devel, netdev, linux-kernel, Kirsher, Jeffrey T,
Allan, Bruce W, Waskiewicz Jr, Peter P, Ronciak, John
Jiri Slaby wrote:
> There were 2 omitted readb's used on an iomap space. eliminate them
> by using ioread8 instead.
>
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
> Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Cc: Bruce Allan <bruce.w.allan@intel.com>
> Cc: PJ Waskiewicz <peter.p.waskiewicz.jr@intel.com>
> Cc: John Ronciak <john.ronciak@intel.com>
Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] NET: e100, fix iomap read
2008-08-14 16:27 [PATCH 1/1] NET: e100, fix iomap read Jiri Slaby
2008-08-14 16:29 ` Brandeburg, Jesse
@ 2008-08-27 9:56 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2008-08-27 9:56 UTC (permalink / raw)
To: Jiri Slaby
Cc: e1000-devel, netdev, linux-kernel, Jeff Kirsher, Jesse Brandeburg,
Bruce Allan, PJ Waskiewicz, John Ronciak
Jiri Slaby wrote:
> There were 2 omitted readb's used on an iomap space. eliminate them
> by using ioread8 instead.
>
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
> Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Cc: Bruce Allan <bruce.w.allan@intel.com>
> Cc: PJ Waskiewicz <peter.p.waskiewicz.jr@intel.com>
> Cc: John Ronciak <john.ronciak@intel.com>
> ---
> drivers/net/e100.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-08-27 9:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-14 16:27 [PATCH 1/1] NET: e100, fix iomap read Jiri Slaby
2008-08-14 16:29 ` Brandeburg, Jesse
2008-08-27 9:56 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).