netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Dumazet <dada1@cosmosbay.com>
To: David Miller <davem@davemloft.net>
Cc: andi@firstfloor.org, davej@redhat.com, netdev@vger.kernel.org,
	j.w.r.degoede@hhs.nl
Subject: Re: cat /proc/net/tcp takes 0.5 seconds on x86_64
Date: Thu, 28 Aug 2008 01:09:19 +0200	[thread overview]
Message-ID: <48B5DE9F.4010000@cosmosbay.com> (raw)
In-Reply-To: <20080827.153907.157997966.davem@davemloft.net>

David Miller a écrit :
> From: Andi Kleen <andi@firstfloor.org>
> Date: Thu, 28 Aug 2008 00:34:10 +0200
> 
>> It fixes an old performance problem at least. I'm not aware 
>> of any new ones in this area because the code in this 
>> function hasn't changed since I last looked.
> 
> That's exactly what this thread is about, things got slower for
> some reason even though nothing specifically changed in this area.
> 
> I wonder if indirectly something changed in how the hash table
> allocator code down in mm/*.c works, perhaps it's taking NUMA
> into account differently now?
> 

Not really, I suspect commit (a7ab4b501f9b8a9dc4d5cee542db67b6ccd1088b 
[TCPv4]: Improve BH latency in /proc/net/tcp) is responsible for longer delays.
Note that its rather old :
Date:   Sun Jun 10 17:33:08 2007 -0700


We used to disable bh once, while reading the table. This sucked.

In case machine is handling trafic, we now are preemptable by softirqs
while reading /proc/net/tcp. Thats a good thing.

By the way, I find Andi patch usefull. Same thing could be done for /proc/net/rt_cache.




  parent reply	other threads:[~2008-08-27 23:09 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-459782-176318@bugzilla.redhat.com>
     [not found] ` <200808261549.m7QFnVUN032543@bz-web1.app.phx.redhat.com>
2008-08-26 16:37   ` cat /proc/net/tcp takes 0.5 seconds on x86_64 Dave Jones
2008-08-26 18:32     ` Eric Dumazet
2008-08-26 19:01       ` Hans de Goede
2008-08-26 20:39         ` Eric Dumazet
2008-08-26 20:58           ` Hans de Goede
2008-08-26 21:27             ` Eric Dumazet
2008-08-27  9:14               ` Hans de Goede
2008-08-27  9:05                 ` David Miller
2008-08-27  9:45                   ` Hans de Goede
2008-08-27  9:39                     ` David Miller
2008-08-27  4:19         ` Herbert Xu
2008-08-27  9:07           ` Hans de Goede
2008-08-27 12:41     ` Andi Kleen
2008-08-27 21:29       ` Trent Piepho
2008-08-27 21:47         ` Andi Kleen
2008-08-27 22:54           ` Andi Kleen
2008-08-27 21:29       ` David Miller
2008-08-27 21:48         ` Stephen Hemminger
2008-08-27 22:09           ` David Miller
2008-08-28  6:20             ` Eric Dumazet
2008-08-28  6:51               ` David Miller
2008-08-28  7:13                 ` Eric Dumazet
2008-08-28  7:57                   ` David Miller
2008-08-28  9:52                     ` Eric Dumazet
2008-08-28  7:26               ` Andi Kleen
2008-08-27 22:34         ` Andi Kleen
2008-08-27 22:39           ` David Miller
2008-08-27 22:57             ` Andi Kleen
2008-08-27 23:07               ` David Miller
2008-08-27 23:09             ` Eric Dumazet [this message]
2008-08-27 23:15               ` David Miller
2008-08-27 23:35                 ` Andi Kleen
2008-08-27 23:43                 ` Eric Dumazet
2008-08-27 23:45                   ` David Miller
2008-08-28  0:40                     ` Eric Dumazet
2008-08-28  7:45                       ` Andi Kleen
2008-08-28  7:59                         ` David Miller
2008-08-28  8:12                           ` Hans de Goede
2008-08-28  8:04                             ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48B5DE9F.4010000@cosmosbay.com \
    --to=dada1@cosmosbay.com \
    --cc=andi@firstfloor.org \
    --cc=davej@redhat.com \
    --cc=davem@davemloft.net \
    --cc=j.w.r.degoede@hhs.nl \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).