From: Alexander Duyck <alexander.h.duyck@intel.com>
To: Jarek Poplawski <jarkao2@gmail.com>
Cc: Alexander Duyck <alexander.duyck@gmail.com>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"jeff@garzik.org" <jeff@garzik.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [UPDATED] [NET-NEXT PATCH 1/2] pkt_sched: Add multiqueue scheduler support
Date: Tue, 02 Sep 2008 13:53:02 -0700 [thread overview]
Message-ID: <48BDA7AE.3080103@intel.com> (raw)
In-Reply-To: <20080902200953.GA2544@ami.dom.local>
Jarek Poplawski wrote:
> Right. But since this doesn't cause this additional blocking I'm not
> sure there is a reason to forbid this. IMHO documenting this could be
> enough, and letting to do this could be useful even for testing. But,
> of course, you are the author, so I don't persist with this.
>
> Thanks,
> Jarek P.
You are correct in that it doesn't cause any additional blocking, but it
does break the way that the prio qdisc is supposed to work. I figure it
is best to keep all the qdiscs behaving the way they are supposed to
without my qdisc changing their behavior by acting as a leaf.
Thanks for all the useful input.
Alex
next prev parent reply other threads:[~2008-09-02 20:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-30 7:23 [UPDATED] [NET-NEXT PATCH 1/2] pkt_sched: Add multiqueue scheduler support Jeff Kirsher
2008-08-30 7:24 ` [UPDATED] [NET-NEXT PATCH 2/2] pkt_action: add new action skbedit Jeff Kirsher
2008-09-02 12:27 ` Jarek Poplawski
2008-09-01 21:05 ` [UPDATED] [NET-NEXT PATCH 1/2] pkt_sched: Add multiqueue scheduler support Jarek Poplawski
2008-09-01 22:49 ` Alexander Duyck
2008-09-02 5:54 ` Jarek Poplawski
2008-09-02 7:52 ` Jarek Poplawski
2008-09-02 17:18 ` Duyck, Alexander H
2008-09-02 20:09 ` Jarek Poplawski
2008-09-02 20:53 ` Alexander Duyck [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-08-30 7:21 Jeff Kirsher
2008-09-12 3:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48BDA7AE.3080103@intel.com \
--to=alexander.h.duyck@intel.com \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=jarkao2@gmail.com \
--cc=jeff@garzik.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).