netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Duyck <alexander.h.duyck@intel.com>
To: Thomas Graf <tgraf@suug.ch>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [RESEND 2.6.27] netlink: Remove compat API for nested attributes
Date: Tue, 02 Sep 2008 17:27:28 -0700	[thread overview]
Message-ID: <48BDD9F0.8090706@intel.com> (raw)
In-Reply-To: <20080902232008.GD20815@postel.suug.ch>

Thomas Graf wrote:
> Ever since the multiqueue bits have been removed from prio in net-next,
> prio no longer requires the compat functions which leaves netem as the
> sole user. As you know, netem isn't really using the "compat" format but
> instead uses its own format which was the origin of all this trouble.
> Therefore I propose to move the current nla_parse_nested_compat() code
> to netem and remove the API alltogether since there is no real user of
> the original compat interface anymore. Leaving them around would only
> encourage new code to use it.

That is the point of code like this.  It defines a standard set of tools 
for extending an existing netlink interface.  If nothing else we should 
standardize on the netem approach for both parsing and creation since 
prio no longer ueses the compat attributes.

> Note that this patch is against the net-next tree which is not affected
> by the prio regression (as the multiqueue bits have been removed) and
> does not aim at resolving the regression. See my separate patch against
> the stable tree which aims at resovling the prio regression.
> Alternatively, reverting Patrick's and my patch in the stable tree is
> perfectly fine with me as well.

I saw your patches against the stable trees, and I would be happy with 
your solution or the reverting of the patches as long as one of them is 
implemented.

Thanks,

Alex

  reply	other threads:[~2008-09-03  0:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-28 14:00 [PATCH 2.6.27] netlink: Remove compat API for nested attributes Thomas Graf
2008-08-28 14:05 ` [RESEND " Thomas Graf
2008-09-02 21:46   ` Alexander Duyck
2008-09-02 23:04     ` David Miller
2008-09-02 23:20     ` Thomas Graf
2008-09-03  0:27       ` Alexander Duyck [this message]
2008-09-03  0:34         ` David Miller
2008-09-03  0:30   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48BDD9F0.8090706@intel.com \
    --to=alexander.h.duyck@intel.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).