netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Siim Põder" <siim@p6drad-teel.net>
To: netdev@vger.kernel.org, lvs-devel@vger.kernel.org
Cc: Simon Horman <horms@verge.net.au>
Subject: A one-liner ipvs patch
Date: Wed, 03 Sep 2008 11:24:03 +0300	[thread overview]
Message-ID: <48BE49A3.9030201@p6drad-teel.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 487 bytes --]

Hi!

I have a few very high connection rate services behind LVS and when
keepalived removes them because of problems, the LVS would be rebooted
with tens of thousands of this message in the logs (rebooted by hardware
watchdogs).

I have had it running on production systems for maybe 3 months or so and
this problem hasn't occured any more, which does not prove that the
patch isn't just curing a symptom, but I think it is concievable, that a
lot of printks could hang a system.

Siim


[-- Attachment #2: ip_vs_wrr-ratelimit-printk.patch --]
[-- Type: text/x-patch, Size: 671 bytes --]

ipvs: ratelimit flooding message in wrr scheduler

When all backends are removed from wrr scheduler by a monitoring agent, this
message can flood so fast that a 10s watchdog would reset the system.

Signed-off-by: Siim Po~der <siim@p6drad-teel.net>
--- linux-2.6.24/net/ipv4/ipvs/ip_vs_wrr.c	2008-01-24 22:58:37.000000000 +0000
+++ linux-2.6.24-ipvs_patches/net/ipv4/ipvs/ip_vs_wrr.c	2008-05-06 16:17:17.790662800 +0000
@@ -169,7 +169,7 @@
 				 */
 				if (mark->cw == 0) {
 					mark->cl = &svc->destinations;
-					IP_VS_INFO("ip_vs_wrr_schedule(): "
+					IP_VS_DBG_RL("ip_vs_wrr_schedule(): "
 						   "no available servers\n");
 					dest = NULL;
 					goto out;


             reply	other threads:[~2008-09-03  8:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-03  8:24 Siim Põder [this message]
2008-09-03  8:47 ` A one-liner ipvs patch Simon Horman
2008-09-03  9:02 ` Siim Põder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48BE49A3.9030201@p6drad-teel.net \
    --to=siim@p6drad-teel.net \
    --cc=horms@verge.net.au \
    --cc=lvs-devel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).