netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ixgbe: initialize interrupt throttle rate
@ 2008-08-28  1:04 Jeff Kirsher
  2008-09-03 13:27 ` Jeff Garzik
  0 siblings, 1 reply; 2+ messages in thread
From: Jeff Kirsher @ 2008-08-28  1:04 UTC (permalink / raw)
  To: jeff; +Cc: netdev, davem, stable, andy, jesse.brandeburg, jeffrey.t.kirsher

From: Andy Gospodarek <andy@greyhouse.net>

This commit dropped the setting of the default interrupt throttle rate.

commit 021230d40ae0e6508d6c717b6e0d6d81cd77ac25
Author: Ayyappan Veeraiyan <ayyappan.veeraiyan@intel.com>
Date:   Mon Mar 3 15:03:45 2008 -0800

    ixgbe: Introduce MSI-X queue vector code

The following patch adds it back.  Without this the default value of 0
causes the performance of this card to be awful.  Restoring these to the
default values yields much better performance.

This regression has been around since 2.6.25.

Signed-off-by: Andy Gospodarek <andy@greyhouse.net>
Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
CC: stable@kernel.org [2.6.25 and later]
---

 drivers/net/ixgbe/ixgbe_main.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
index 53f41b6..a417be7 100644
--- a/drivers/net/ixgbe/ixgbe_main.c
+++ b/drivers/net/ixgbe/ixgbe_main.c
@@ -2304,6 +2304,12 @@ static int __devinit ixgbe_set_interrupt_capability(struct ixgbe_adapter
 	int vector, v_budget;
 
 	/*
+	 * Set the default interrupt throttle rate.
+	 */
+	adapter->rx_eitr = (1000000 / IXGBE_DEFAULT_ITR_RX_USECS);
+	adapter->tx_eitr = (1000000 / IXGBE_DEFAULT_ITR_TX_USECS);
+
+	/*
 	 * It's easy to be greedy for MSI-X vectors, but it really
 	 * doesn't do us much good if we have a lot more vectors
 	 * than CPU's.  So let's be conservative and only ask for


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ixgbe: initialize interrupt throttle rate
  2008-08-28  1:04 [PATCH] ixgbe: initialize interrupt throttle rate Jeff Kirsher
@ 2008-09-03 13:27 ` Jeff Garzik
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-09-03 13:27 UTC (permalink / raw)
  To: Jeff Kirsher; +Cc: netdev, davem, stable, andy, jesse.brandeburg

Jeff Kirsher wrote:
> From: Andy Gospodarek <andy@greyhouse.net>
> 
> This commit dropped the setting of the default interrupt throttle rate.
> 
> commit 021230d40ae0e6508d6c717b6e0d6d81cd77ac25
> Author: Ayyappan Veeraiyan <ayyappan.veeraiyan@intel.com>
> Date:   Mon Mar 3 15:03:45 2008 -0800
> 
>     ixgbe: Introduce MSI-X queue vector code
> 
> The following patch adds it back.  Without this the default value of 0
> causes the performance of this card to be awful.  Restoring these to the
> default values yields much better performance.
> 
> This regression has been around since 2.6.25.
> 
> Signed-off-by: Andy Gospodarek <andy@greyhouse.net>
> Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> CC: stable@kernel.org [2.6.25 and later]
> ---
> 
>  drivers/net/ixgbe/ixgbe_main.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)

applied



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-09-03 13:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-28  1:04 [PATCH] ixgbe: initialize interrupt throttle rate Jeff Kirsher
2008-09-03 13:27 ` Jeff Garzik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).