netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: mingo@elte.hu, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, davem@davemloft.net,
	akpm@linux-foundation.org,
	Jesse Brandeburg <jesse.brandeburg@intel.com>
Subject: Re: [NET-NEXT PATCH] e1000: remove unused Kconfig option for disabling packet split
Date: Wed, 03 Sep 2008 09:59:08 -0400	[thread overview]
Message-ID: <48BE982C.20705@garzik.org> (raw)
In-Reply-To: <20080827081956.11114.152.stgit@jtkirshe-mobile.jf.intel.com>

Jeff Kirsher wrote:
> From: Jesse Brandeburg <jesse.brandeburg@intel.com>
> 
> Since the e1000/e1000e split, no hardware supported by e1000
> supports packet split, just remove the Kconfig option and associated
> code from arch/* and the driver.
> 
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> ---
> 
>  arch/arm/configs/iop13xx_defconfig              |    1 
>  arch/arm/configs/iop32x_defconfig               |    1 
>  arch/arm/configs/iop33x_defconfig               |    1 
>  arch/arm/configs/ixp23xx_defconfig              |    1 
>  arch/arm/configs/kirkwood_defconfig             |    1 
>  arch/ia64/configs/generic_defconfig             |    1 
>  arch/ia64/configs/gensparse_defconfig           |    1 
>  arch/ia64/configs/tiger_defconfig               |    1 
>  arch/ia64/configs/zx1_defconfig                 |    1 
>  arch/mips/configs/mtx1_defconfig                |    1 
>  arch/parisc/configs/a500_defconfig              |    1 
>  arch/parisc/configs/c3000_defconfig             |    1 
>  arch/powerpc/configs/83xx/mpc832x_rdb_defconfig |    1 
>  arch/powerpc/configs/85xx/mpc8560_ads_defconfig |    1 
>  arch/powerpc/configs/85xx/mpc85xx_cds_defconfig |    1 
>  arch/powerpc/configs/85xx/tqm8548_defconfig     |    1 
>  arch/powerpc/configs/cell_defconfig             |    1 
>  arch/powerpc/configs/g5_defconfig               |    1 
>  arch/powerpc/configs/iseries_defconfig          |    1 
>  arch/powerpc/configs/maple_defconfig            |    1 
>  arch/powerpc/configs/pasemi_defconfig           |    1 
>  arch/powerpc/configs/ppc64_defconfig            |    1 
>  arch/powerpc/configs/ppc6xx_defconfig           |    1 
>  arch/powerpc/configs/prpmc2800_defconfig        |    1 
>  arch/powerpc/configs/pseries_defconfig          |    1 
>  arch/sh/configs/r7780mp_defconfig               |    1 
>  arch/sparc64/defconfig                          |    1 
>  arch/x86/configs/i386_defconfig                 |    1 
>  arch/x86/configs/x86_64_defconfig               |    1 
>  drivers/net/Kconfig                             |    9 
>  drivers/net/e1000/e1000.h                       |   17 -
>  drivers/net/e1000/e1000_main.c                  |  416 -----------------------
>  32 files changed, 9 insertions(+), 462 deletions(-)

ACK, except for the defconfig changes.  arch maintainers usually prefer 
to do that themselves.

We'd be continually patch defconfig files, if we did so every time it 
was likely one would be updated by a Kconfig patch.



  reply	other threads:[~2008-09-03 13:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-27  8:19 [NET-NEXT PATCH] e1000: remove unused Kconfig option for disabling packet split Jeff Kirsher
2008-09-03 13:59 ` Jeff Garzik [this message]
2008-09-16 20:01   ` Brandeburg, Jesse
2008-09-25  2:14     ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48BE982C.20705@garzik.org \
    --to=jeff@garzik.org \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).