netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: adobriyan@gmail.com
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
	containers@lists.linux-foundation.org
Subject: Re: [PATCH 07/38] netns ct: add ->ct_net -- pointer from conntrack to netns
Date: Thu, 04 Sep 2008 18:18:22 +0200	[thread overview]
Message-ID: <48C00A4E.5060103@trash.net> (raw)
In-Reply-To: <20080821215934.GG31136@x200.localdomain>

adobriyan@gmail.com wrote:
> Conntrack (struct nf_conn) gets pointer to netns: ->ct_net -- netns in which
> it was created. It comes from netdevice.
> 
> ->ct_net is write-once field.
> 
> Every conntrack in system has ->ct_net initialized, no exceptions.
> 
> ->ct_net doesn't pin netns: conntracks are recycled after timeouts and
> pinning background traffic will prevent netns from even starting shutdown
> sequence.
> 
> Right now every conntrack is created in init_net.

Applied and fixed up another overly long line.

> +		h = init_conntrack(&init_net, &tuple, l3proto, l4proto, skb, dataoff);

This will probably cause clashes later, please don't
do that.

      reply	other threads:[~2008-09-04 16:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-21 21:59 [PATCH 07/38] netns ct: add ->ct_net -- pointer from conntrack to netns adobriyan
2008-09-04 16:18 ` Patrick McHardy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48C00A4E.5060103@trash.net \
    --to=kaber@trash.net \
    --cc=adobriyan@gmail.com \
    --cc=containers@lists.linux-foundation.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).