From: Patrick McHardy <kaber@trash.net>
To: adobriyan@gmail.com
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
containers@lists.linux-foundation.org
Subject: Re: [PATCH 21/25] netns ct: per-netns event cache
Date: Thu, 04 Sep 2008 18:58:38 +0200 [thread overview]
Message-ID: <48C013BE.3060800@trash.net> (raw)
In-Reply-To: <20080821220445.GU31136@x200.localdomain>
adobriyan@gmail.com wrote:
> static inline void
> -nf_conntrack_event_cache(enum ip_conntrack_events event,
> +nf_conntrack_event_cache(struct net *net, enum ip_conntrack_events event,
> const struct sk_buff *skb)
> {
Passing the conntrack instead of the struct net and the skb
would probably keep the callers cleaner.
> struct nf_conn *ct = (struct nf_conn *)skb->nfct;
> struct nf_conntrack_ecache *ecache;
>
> local_bh_disable();
> - ecache = &__get_cpu_var(nf_conntrack_ecache);
> + ecache = per_cpu_ptr(net->ct.ecache, raw_smp_processor_id());
> if (ct != ecache->ct)
> __nf_ct_event_cache_init(ct);
> ecache->events |= event;
> @@ -60,16 +58,29 @@ nf_ct_expect_event(enum ip_conntrack_expect_events event,
> atomic_notifier_call_chain(&nf_ct_expect_chain, event, exp);
> }
>
next prev parent reply other threads:[~2008-09-04 16:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 22:04 [PATCH 21/25] netns ct: per-netns event cache adobriyan
2008-09-04 16:58 ` Patrick McHardy [this message]
2008-09-05 3:44 ` Alexey Dobriyan
2008-09-05 11:34 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C013BE.3060800@trash.net \
--to=kaber@trash.net \
--cc=adobriyan@gmail.com \
--cc=containers@lists.linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).