From: Patrick McHardy <kaber@trash.net>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
containers@lists.linux-foundation.org
Subject: Re: [PATCH 21/25] netns ct: per-netns event cache
Date: Fri, 05 Sep 2008 13:34:39 +0200 [thread overview]
Message-ID: <48C1194F.7030608@trash.net> (raw)
In-Reply-To: <20080905034415.GB2789@x200.localdomain>
Alexey Dobriyan wrote:
> On Thu, Sep 04, 2008 at 06:58:38PM +0200, Patrick McHardy wrote:
>> adobriyan@gmail.com wrote:
>>> static inline void
>>> -nf_conntrack_event_cache(enum ip_conntrack_events event,
>>> +nf_conntrack_event_cache(struct net *net, enum ip_conntrack_events event,
>>> const struct sk_buff *skb)
>>> {
>> Passing the conntrack instead of the struct net and the skb
>> would probably keep the callers cleaner.
>
> Dunno, passing netns explicitly like saying conntrack event happened in
> netns A, which is reasonable. OTOH, s/skb/ct/ is indeed nicer.
>
> I'll change it as you suggest and see what happens.
>
> BTW, I asked earlier if untracked conntracks are ever supposed to drop into
> event cache. If they're, trimming nf_conntrack_untracked is out of question.
No, they are skipped by the only event handler, ctnetlink.
prev parent reply other threads:[~2008-09-05 11:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 22:04 [PATCH 21/25] netns ct: per-netns event cache adobriyan
2008-09-04 16:58 ` Patrick McHardy
2008-09-05 3:44 ` Alexey Dobriyan
2008-09-05 11:34 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C1194F.7030608@trash.net \
--to=kaber@trash.net \
--cc=adobriyan@gmail.com \
--cc=containers@lists.linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).