* Re: mmotm 2008-09-08-18-32 uploaded
[not found] <200809090135.m891ZHiW020337@imap1.linux-foundation.org>
@ 2008-09-09 9:32 ` Jiri Slaby
2008-09-09 15:03 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Slaby @ 2008-09-09 9:32 UTC (permalink / raw)
To: linux-kernel; +Cc: mm-commits, Andrew Morton, netdev, romieu
akpm@linux-foundation.org napsal(a):
> The mm-of-the-moment snapshot 2008-09-08-18-32 has been uploaded to
Hi,
CONFIG_MII=n
CONFIG_R8169=y
causes:
drivers/built-in.o: In function `rtl8169_gset_xmii':
r8169.c:(.text+0x8b4ec): undefined reference to `mii_ethtool_gset'
R8169 should depend on MII?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: mmotm 2008-09-08-18-32 uploaded
2008-09-09 9:32 ` mmotm 2008-09-08-18-32 uploaded Jiri Slaby
@ 2008-09-09 15:03 ` Randy Dunlap
2008-09-10 12:30 ` [PATCH 1/1] NET: fix r8169 linkage Jiri Slaby
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2008-09-09 15:03 UTC (permalink / raw)
To: Jiri Slaby; +Cc: linux-kernel, mm-commits, Andrew Morton, netdev, romieu
On Tue, 09 Sep 2008 11:32:10 +0200 Jiri Slaby wrote:
> akpm@linux-foundation.org napsal(a):
> > The mm-of-the-moment snapshot 2008-09-08-18-32 has been uploaded to
>
> Hi,
>
> CONFIG_MII=n
> CONFIG_R8169=y
>
> causes:
> drivers/built-in.o: In function `rtl8169_gset_xmii':
> r8169.c:(.text+0x8b4ec): undefined reference to `mii_ethtool_gset'
>
> R8169 should depend on MII?
> --
It should select MII. That should change CONFIG_MII to =y.
---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] NET: fix r8169 linkage
2008-09-09 15:03 ` Randy Dunlap
@ 2008-09-10 12:30 ` Jiri Slaby
0 siblings, 0 replies; 3+ messages in thread
From: Jiri Slaby @ 2008-09-10 12:30 UTC (permalink / raw)
To: jgarzik; +Cc: netdev, rdunlap, akpm, linux-kernel, Jiri Slaby, Francois Romieu
R8169 depends on MII code, thus select MII in Kconfig by R8169.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Francois Romieu <romieu@fr.zoreil.com>
Cc: Jeff Garzik <jgarzik@pobox.com>
---
drivers/net/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 4c818d5..b0a5a17 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -2034,6 +2034,7 @@ config R8169
tristate "Realtek 8169 gigabit ethernet support"
depends on PCI
select CRC32
+ select MII
---help---
Say Y here if you have a Realtek 8169 PCI Gigabit Ethernet adapter.
--
1.6.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-09-10 13:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200809090135.m891ZHiW020337@imap1.linux-foundation.org>
2008-09-09 9:32 ` mmotm 2008-09-08-18-32 uploaded Jiri Slaby
2008-09-09 15:03 ` Randy Dunlap
2008-09-10 12:30 ` [PATCH 1/1] NET: fix r8169 linkage Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).