* 2 bugs found in Cisco vpnclient-4.8.02.0030
@ 2008-09-09 12:11 Denis Joseph Barrow
0 siblings, 0 replies; only message in thread
From: Denis Joseph Barrow @ 2008-09-09 12:11 UTC (permalink / raw)
To: Németh Tamás
Cc: Filip Aben, Linux USB kernel mailing list,
Linux netdev Mailing list
[-- Attachment #1: Type: text/plain, Size: 651 bytes --]
Hi Tamas,
I've got the vpn client going over ethernet but not yet over the hso device.
I found 2 idiotic substantial bugs in the vpn client one which caused
the crash in linuxcniapi.c as you were seeing
You'll note that in some places the code was looping to <MAX_INTERFACES
& other places to <=MAX_INTERFACES, this was flying over the edge
of the array.
These bugs are not unique to the hso driver they just happened to
manifest there.
Let me know if you still find crashes somehow, post them to me & more importantly
let me know if you get hso going over vpn.
Please find some way to get the bugfixes back to Cisco.
--
best regards,
D.J. Barrow
[-- Attachment #2: vpnclient.patch --]
[-- Type: text/x-diff, Size: 838 bytes --]
--- cisco-vpn-client.orig/vpnclient-4.8.02.0030/interceptor.c 2008-06-23 18:59:12.000000000 +0200
+++ cisco-vpn-client/vpnclient-4.8.02.0030/interceptor.c 2008-09-09 13:54:02.000000000 +0200
@@ -502,7 +502,7 @@
{
int i;
- for (i=0; i <= MAX_INTERFACES; i++)
+ for (i=0; i < MAX_INTERFACES; i++)
{
BINDING *b = &Bindings[i];
if (b->pDevice && (dev->ifindex == b->pDevice->ifindex))
--- cisco-vpn-client.orig/vpnclient-4.8.02.0030/linuxcniapi.c 2008-06-23 18:59:12.000000000 +0200
+++ cisco-vpn-client/vpnclient-4.8.02.0030/linuxcniapi.c 2008-09-09 13:37:33.000000000 +0200
@@ -577,7 +577,7 @@
{
int i;
- for (i=0; i <= MAX_INTERFACES; i++)
+ for (i=0; i < MAX_INTERFACES; i++)
{
BINDING *b = &Bindings[i];
if (b->pDevice && (iIndex == b->pDevice->ifindex))
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-09-09 12:11 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-09 12:11 2 bugs found in Cisco vpnclient-4.8.02.0030 Denis Joseph Barrow
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).