From: Chris Snook <csnook@redhat.com>
To: Jay Cliburn <jcliburn@gmail.com>
Cc: jeff@garzik.org, netdev@vger.kernel.org, atl2-test@lists.sourceforge.net
Subject: Re: [PATCH 2/4] atlx: add atl2.h
Date: Tue, 09 Sep 2008 22:12:31 -0400 [thread overview]
Message-ID: <48C72D0F.6020803@redhat.com> (raw)
In-Reply-To: <20080909204300.43e38187@osprey.hogchain.net>
Jay Cliburn wrote:
> On Tue, 9 Sep 2008 02:19:45 -0400
> Chris Snook <csnook@redhat.com> wrote:
>
>> From: Chris Snook <csnook@redhat.com>
>>
>> Header file for atl2 support.
>>
>> Signed-off-by: Chris Snook <csnook@redhat.com>
>
> Checkpatch.pl reports some coding style and whitespace issues.
>
> total: 83 errors, 46 warnings, 482 lines checked
Wow, that's actually better than I was expecting. I'm posting it as-is because
it's ridiculous for people to wait yet another release for this to hit mainline,
just for cosmetic reasons. People are using this driver all over the place, and
nobody is working on fixing the initialization bugs and implementing ethtool
ioctls while it's sitting in my kscope window waiting for me to clean up the
rest of the whitespace.
I recommend we merge it anyway, though I admit it needs cleanup.
-- Chris
next prev parent reply other threads:[~2008-09-10 2:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-09 6:12 [PATCH 0/4] atlx: add atl2 support Chris Snook
2008-09-09 6:15 ` [PATCH 1/4] atlx: add atl2 pci id Chris Snook
2008-09-09 6:19 ` [PATCH 2/4] atlx: add atl2.h Chris Snook
2008-09-10 1:43 ` Jay Cliburn
2008-09-10 2:12 ` Chris Snook [this message]
2008-09-09 6:22 ` [PATCH 3/4] atlx: add atl2.c Chris Snook
2008-09-10 1:44 ` Jay Cliburn
2008-09-10 2:16 ` Chris Snook
2008-09-09 6:24 ` [PATCH 4/4] atlx: update build files for atl2 Chris Snook
2008-09-10 1:47 ` Jay Cliburn
2008-09-10 2:24 ` Chris Snook
2008-09-09 6:32 ` [PATCH 0/4] atlx: add atl2 support Chris Snook
2008-09-10 1:49 ` Jay Cliburn
2008-09-10 1:58 ` Jay Cliburn
2008-09-13 19:40 ` Jeff Garzik
2008-09-14 22:14 ` Chris Snook
2008-09-15 3:21 ` Jeff Garzik
2008-09-15 3:26 ` Chris Snook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C72D0F.6020803@redhat.com \
--to=csnook@redhat.com \
--cc=atl2-test@lists.sourceforge.net \
--cc=jcliburn@gmail.com \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).