From: Chris Snook <csnook@redhat.com>
To: Jay Cliburn <jcliburn@gmail.com>
Cc: jeff@garzik.org, netdev@vger.kernel.org, atl2-test@lists.sourceforge.net
Subject: Re: [PATCH 3/4] atlx: add atl2.c
Date: Tue, 09 Sep 2008 22:16:54 -0400 [thread overview]
Message-ID: <48C72E16.7050509@redhat.com> (raw)
In-Reply-To: <20080909204413.745b43e7@osprey.hogchain.net>
Jay Cliburn wrote:
> On Tue, 9 Sep 2008 02:22:13 -0400
> Chris Snook <csnook@redhat.com> wrote:
>
>> From: Chris Snook <csnook@redhat.com>
>>
>> Add the atl2 implementation.
>>
>> Signed-off-by: Chris Snook <csnook@redhat.com>
>
> Checkpatch.pl reports coding style and whitespace issues.
>
> total: 179 errors, 55 warnings, 3101 lines checked
As with atl2.h, this is expected. Most of this be taken care of when we unify
the atl1 and atl2 code into the atlx code, and the rest will be short work.
We can do a lot of cosmetic cleanup before 2.6.28 is released, but I think it's
important we get this into linux-next (and later the -git kernels) and get more
widespread functional testing before that happens.
-- Chris
next prev parent reply other threads:[~2008-09-10 2:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-09 6:12 [PATCH 0/4] atlx: add atl2 support Chris Snook
2008-09-09 6:15 ` [PATCH 1/4] atlx: add atl2 pci id Chris Snook
2008-09-09 6:19 ` [PATCH 2/4] atlx: add atl2.h Chris Snook
2008-09-10 1:43 ` Jay Cliburn
2008-09-10 2:12 ` Chris Snook
2008-09-09 6:22 ` [PATCH 3/4] atlx: add atl2.c Chris Snook
2008-09-10 1:44 ` Jay Cliburn
2008-09-10 2:16 ` Chris Snook [this message]
2008-09-09 6:24 ` [PATCH 4/4] atlx: update build files for atl2 Chris Snook
2008-09-10 1:47 ` Jay Cliburn
2008-09-10 2:24 ` Chris Snook
2008-09-09 6:32 ` [PATCH 0/4] atlx: add atl2 support Chris Snook
2008-09-10 1:49 ` Jay Cliburn
2008-09-10 1:58 ` Jay Cliburn
2008-09-13 19:40 ` Jeff Garzik
2008-09-14 22:14 ` Chris Snook
2008-09-15 3:21 ` Jeff Garzik
2008-09-15 3:26 ` Chris Snook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C72E16.7050509@redhat.com \
--to=csnook@redhat.com \
--cc=atl2-test@lists.sourceforge.net \
--cc=jcliburn@gmail.com \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).