From: Chris Snook <csnook@redhat.com>
To: Jay Cliburn <jcliburn@gmail.com>
Cc: jeff@garzik.org, netdev@vger.kernel.org, atl2-test@lists.sourceforge.net
Subject: Re: [PATCH 4/4] atlx: update build files for atl2
Date: Tue, 09 Sep 2008 22:24:09 -0400 [thread overview]
Message-ID: <48C72FC9.10308@redhat.com> (raw)
In-Reply-To: <20080909204702.340c2205@osprey.hogchain.net>
Jay Cliburn wrote:
> On Tue, 9 Sep 2008 02:24:41 -0400
> Chris Snook <csnook@redhat.com> wrote:
>
>> From: Chris Snook <csnook@redhat.com>
>>
>> Add the Kconfig and Makefile entries for atl2. Also remove the
>> EXPERIMENTAL label from atl1, as it is now quite mature.
>>
>> Signed-off-by: Chris Snook <csnook@redhat.com>
>
> Patch doesn't apply against current Linus' git. Also, this is a Fast
> Ethernet device, so it probably shouldn't be in the 1000 Mbit Kconfig
> section. This patch fixes it.
Oops. Brain gets tired after thousands of lines of whitespace cleanup. Thanks
for fixing it.
Acked-by: Chris Snook <csnook@redhat.com>
> commit f4b4f597e623ffae70947844a8e6431a58502439
> Author: Jay Cliburn <jacliburn@bellsouth.net>
> Date: Tue Sep 9 20:31:58 2008 -0500
>
> atl2: kconfig and makefile changes for atl2
>
> Add Kconfig and Makefile changes to merge the atl2 driver.
>
> Signed-off-by: Jay Cliburn <jacliburn@bellsouth.net>
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index 4a11296..81a3e95 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -1840,6 +1840,17 @@ config NE_H8300
> Say Y here if you want to use the NE2000 compatible
> controller on the Renesas H8/300 processor.
>
> +config ATL2
> + tristate "Atheros L2 Fast Ethernet support"
> + depends on PCI
> + select CRC32
> + select MII
> + help
> + This driver supports the Atheros L2 fast ethernet adapter.
> +
> + To compile this driver as a module, choose M here. The module
> + will be called atl2.
> +
> source "drivers/net/fs_enet/Kconfig"
>
> endif # NET_ETHERNET
> diff --git a/drivers/net/Makefile b/drivers/net/Makefile
> index 7629c90..eda7b12 100644
> --- a/drivers/net/Makefile
> +++ b/drivers/net/Makefile
> @@ -15,6 +15,7 @@ obj-$(CONFIG_EHEA) += ehea/
> obj-$(CONFIG_CAN) += can/
> obj-$(CONFIG_BONDING) += bonding/
> obj-$(CONFIG_ATL1) += atlx/
> +obj-$(CONFIG_ATL2) += atlx/
> obj-$(CONFIG_ATL1E) += atl1e/
> obj-$(CONFIG_GIANFAR) += gianfar_driver.o
> obj-$(CONFIG_TEHUTI) += tehuti.o
> diff --git a/drivers/net/atlx/Makefile b/drivers/net/atlx/Makefile
> index ca45553..e4f6022 100644
> --- a/drivers/net/atlx/Makefile
> +++ b/drivers/net/atlx/Makefile
> @@ -1 +1,3 @@
> obj-$(CONFIG_ATL1) += atl1.o
> +obj-$(CONFIG_ATL2) += atl2.o
> +
>
next prev parent reply other threads:[~2008-09-10 2:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-09 6:12 [PATCH 0/4] atlx: add atl2 support Chris Snook
2008-09-09 6:15 ` [PATCH 1/4] atlx: add atl2 pci id Chris Snook
2008-09-09 6:19 ` [PATCH 2/4] atlx: add atl2.h Chris Snook
2008-09-10 1:43 ` Jay Cliburn
2008-09-10 2:12 ` Chris Snook
2008-09-09 6:22 ` [PATCH 3/4] atlx: add atl2.c Chris Snook
2008-09-10 1:44 ` Jay Cliburn
2008-09-10 2:16 ` Chris Snook
2008-09-09 6:24 ` [PATCH 4/4] atlx: update build files for atl2 Chris Snook
2008-09-10 1:47 ` Jay Cliburn
2008-09-10 2:24 ` Chris Snook [this message]
2008-09-09 6:32 ` [PATCH 0/4] atlx: add atl2 support Chris Snook
2008-09-10 1:49 ` Jay Cliburn
2008-09-10 1:58 ` Jay Cliburn
2008-09-13 19:40 ` Jeff Garzik
2008-09-14 22:14 ` Chris Snook
2008-09-15 3:21 ` Jeff Garzik
2008-09-15 3:26 ` Chris Snook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C72FC9.10308@redhat.com \
--to=csnook@redhat.com \
--cc=atl2-test@lists.sourceforge.net \
--cc=jcliburn@gmail.com \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).