* [PATCH] Fix dead 21041 ethernet after ifconfig down
@ 2008-09-12 21:19 Thomas Bogendoerfer
2008-09-13 18:05 ` Grant Grundler
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Bogendoerfer @ 2008-09-12 21:19 UTC (permalink / raw)
To: netdev; +Cc: grundler, kyle, tbm
The de2104x did a pci_disable_device() in it's close function, but
the open function never does a pci_enable_device() and assumes that
the device is already enabled. Considering that downing the interface
is just a temporary thing the pci_disable_device() isn't a pretty good
idea and removing it from the close function just fixes the bug.
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
---
drivers/net/tulip/de2104x.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/tulip/de2104x.c b/drivers/net/tulip/de2104x.c
index 9281d06..f54c450 100644
--- a/drivers/net/tulip/de2104x.c
+++ b/drivers/net/tulip/de2104x.c
@@ -1418,7 +1418,6 @@ static int de_close (struct net_device *dev)
de_free_rings(de);
de_adapter_sleep(de);
- pci_disable_device(de->pdev);
return 0;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix dead 21041 ethernet after ifconfig down
2008-09-12 21:19 [PATCH] Fix dead 21041 ethernet after ifconfig down Thomas Bogendoerfer
@ 2008-09-13 18:05 ` Grant Grundler
2008-09-13 19:06 ` Jeff Garzik
0 siblings, 1 reply; 3+ messages in thread
From: Grant Grundler @ 2008-09-13 18:05 UTC (permalink / raw)
To: Thomas Bogendoerfer; +Cc: netdev, grundler, kyle, tbm
On Fri, Sep 12, 2008 at 11:19:19PM +0200, Thomas Bogendoerfer wrote:
> The de2104x did a pci_disable_device() in it's close function, but
> the open function never does a pci_enable_device() and assumes that
> the device is already enabled. Considering that downing the interface
> is just a temporary thing the pci_disable_device() isn't a pretty good
> idea and removing it from the close function just fixes the bug.
Thomas,
Thanks for the patch!
The de2104 driver is calling pci_enable_device() in it's .probe routine
and calls pci_disable_device in it's .remove function.
It never occurred to me a NIC driver would call either pci function
from someplace else as well.
> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Acked-by: Grant Grundler <grundler@parisc-linux.org>
> ---
>
> drivers/net/tulip/de2104x.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/tulip/de2104x.c b/drivers/net/tulip/de2104x.c
> index 9281d06..f54c450 100644
> --- a/drivers/net/tulip/de2104x.c
> +++ b/drivers/net/tulip/de2104x.c
> @@ -1418,7 +1418,6 @@ static int de_close (struct net_device *dev)
>
> de_free_rings(de);
> de_adapter_sleep(de);
> - pci_disable_device(de->pdev);
> return 0;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix dead 21041 ethernet after ifconfig down
2008-09-13 18:05 ` Grant Grundler
@ 2008-09-13 19:06 ` Jeff Garzik
0 siblings, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2008-09-13 19:06 UTC (permalink / raw)
To: Grant Grundler; +Cc: Thomas Bogendoerfer, netdev, kyle, tbm
Grant Grundler wrote:
> On Fri, Sep 12, 2008 at 11:19:19PM +0200, Thomas Bogendoerfer wrote:
>> The de2104x did a pci_disable_device() in it's close function, but
>> the open function never does a pci_enable_device() and assumes that
>> the device is already enabled. Considering that downing the interface
>> is just a temporary thing the pci_disable_device() isn't a pretty good
>> idea and removing it from the close function just fixes the bug.
>
> Thomas,
> Thanks for the patch!
>
> The de2104 driver is calling pci_enable_device() in it's .probe routine
> and calls pci_disable_device in it's .remove function.
> It never occurred to me a NIC driver would call either pci function
> from someplace else as well.
>
>> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
>
> Acked-by: Grant Grundler <grundler@parisc-linux.org>
>
>> ---
>>
>> drivers/net/tulip/de2104x.c | 1 -
>> 1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/net/tulip/de2104x.c b/drivers/net/tulip/de2104x.c
>> index 9281d06..f54c450 100644
>> --- a/drivers/net/tulip/de2104x.c
>> +++ b/drivers/net/tulip/de2104x.c
>> @@ -1418,7 +1418,6 @@ static int de_close (struct net_device *dev)
>>
>> de_free_rings(de);
>> de_adapter_sleep(de);
>> - pci_disable_device(de->pdev);
applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-09-13 19:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-12 21:19 [PATCH] Fix dead 21041 ethernet after ifconfig down Thomas Bogendoerfer
2008-09-13 18:05 ` Grant Grundler
2008-09-13 19:06 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).