* [PATCH] smc91x: fix nowait printout
@ 2008-09-08 5:02 Magnus Damm
2008-09-13 19:12 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Magnus Damm @ 2008-09-08 5:02 UTC (permalink / raw)
To: netdev; +Cc: eric.miao, Magnus Damm, nico
From: Magnus Damm <damm@igel.co.jp>
Commit c4f0e76747e80578a8f7fddd82fd0ce8127bd2f8 added nowait platform
data support. The printout code was however not updated, so the value
of SMC_NOWAIT is still used. This patch makes sure that nowait is printed
accordingly to platform data.
Signed-off-by: Magnus Damm <damm@igel.co.jp>
---
drivers/net/smc91x.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- 0001/drivers/net/smc91x.c
+++ work/drivers/net/smc91x.c 2008-09-03 18:42:56.000000000 +0900
@@ -1961,7 +1961,8 @@ static int __init smc_probe(struct net_d
if (dev->dma != (unsigned char)-1)
printk(" DMA %d", dev->dma);
- printk("%s%s\n", nowait ? " [nowait]" : "",
+ printk("%s%s\n",
+ lp->cfg.flags & SMC91X_NOWAIT ? " [nowait]" : "",
THROTTLE_TX_PKTS ? " [throttle_tx]" : "");
if (!is_valid_ether_addr(dev->dev_addr)) {
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] smc91x: fix nowait printout
2008-09-08 5:02 [PATCH] smc91x: fix nowait printout Magnus Damm
@ 2008-09-13 19:12 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-09-13 19:12 UTC (permalink / raw)
To: Magnus Damm; +Cc: netdev, eric.miao, nico
Magnus Damm wrote:
> From: Magnus Damm <damm@igel.co.jp>
>
> Commit c4f0e76747e80578a8f7fddd82fd0ce8127bd2f8 added nowait platform
> data support. The printout code was however not updated, so the value
> of SMC_NOWAIT is still used. This patch makes sure that nowait is printed
> accordingly to platform data.
>
> Signed-off-by: Magnus Damm <damm@igel.co.jp>
> ---
>
> drivers/net/smc91x.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- 0001/drivers/net/smc91x.c
> +++ work/drivers/net/smc91x.c 2008-09-03 18:42:56.000000000 +0900
> @@ -1961,7 +1961,8 @@ static int __init smc_probe(struct net_d
> if (dev->dma != (unsigned char)-1)
> printk(" DMA %d", dev->dma);
>
> - printk("%s%s\n", nowait ? " [nowait]" : "",
> + printk("%s%s\n",
> + lp->cfg.flags & SMC91X_NOWAIT ? " [nowait]" : "",
> THROTTLE_TX_PKTS ? " [throttle_tx]" : "");
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-09-13 19:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-08 5:02 [PATCH] smc91x: fix nowait printout Magnus Damm
2008-09-13 19:12 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).