From: Jeff Garzik <jeff@garzik.org>
To: Brice Goglin <brice@myri.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2.6.28 1/4] myri10ge: Stop scaring people when DCA is built but absent
Date: Sat, 13 Sep 2008 15:30:22 -0400 [thread overview]
Message-ID: <48CC14CE.4050904@garzik.org> (raw)
In-Reply-To: <48CAAB2E.6010408@myri.com>
Brice Goglin wrote:
> Stop scaring people with what looks like a fatal message when DCA support
> is compiled into their kernel, but the DCA device is not present.
>
> Signed-off-by: Brice Goglin <brice@myri.com>
> ---
> drivers/net/myri10ge/myri10ge.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> Index: linux-2.6.git/drivers/net/myri10ge/myri10ge.c
> ===================================================================
> --- linux-2.6.git.orig/drivers/net/myri10ge/myri10ge.c 2008-08-29 07:29:45.000000000 +0200
> +++ linux-2.6.git/drivers/net/myri10ge/myri10ge.c 2008-09-12 19:22:37.000000000 +0200
> @@ -1060,8 +1060,9 @@
> }
> err = dca_add_requester(&pdev->dev);
> if (err) {
> - dev_err(&pdev->dev,
> - "dca_add_requester() failed, err=%d\n", err);
> + if (err != -ENODEV)
> + dev_err(&pdev->dev,
> + "dca_add_requester() failed, err=%d\n", err);
> return;
applied 1-4
next prev parent reply other threads:[~2008-09-13 19:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-12 17:46 [PATCH 2.6.28] myri10ge updates + multiqueue TX Brice Goglin
2008-09-12 17:47 ` [PATCH 2.6.28 1/4] myri10ge: Stop scaring people when DCA is built but absent Brice Goglin
2008-09-13 19:30 ` Jeff Garzik [this message]
2008-09-12 17:48 ` [PATCH 2.6.28 2/4] myri10ge: Rename DCA-related firmware counters Brice Goglin
2008-09-12 17:49 ` [PATCH 2.6.28 3/4] myri10ge: Add Toeplitz-hashing related routines Brice Goglin
2008-09-12 19:54 ` Ben Hutchings
2008-09-12 22:32 ` Duyck, Alexander H
2008-09-12 17:50 ` [PATCH 2.6.28 4/4] myri10ge: Add multiqueue TX support Brice Goglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48CC14CE.4050904@garzik.org \
--to=jeff@garzik.org \
--cc=brice@myri.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).