From: Jeff Garzik <jgarzik@pobox.com>
To: Martin Gebert <martin.gebert@alpha-bit.de>
Cc: netdev@vger.kernel.org
Subject: Re: [Fwd: [PATCH] Spinlock initialisation au1000_eth.c]
Date: Sat, 13 Sep 2008 15:55:32 -0400 [thread overview]
Message-ID: <48CC1AB4.6020200@pobox.com> (raw)
In-Reply-To: <4886E059.9000106@alpha-bit.de>
Martin Gebert wrote:
> Seems like the spinlock for the AU1x00 ethernet device is initialised too
> late, as it is already used in enable_mac(), which is called via
> mii_probe() before the init takes place.
> The attached patch is working here for a Linux Au1100 2.6.22.6 kernel,
> and as far as I checked should also be applicable to the current head
> (just line numbers differ).
>
> Signed-off-by: Martin Gebert <Martin.Gebert@alpha-bit.de>
>
> --- drivers/net/au1000_eth.c 2008-06-26 14:21:53.000000000 +0200
> +++ drivers/net/au1000_eth.c 2008-06-26 14:23:00.000000000 +0200
> @@ -656,6 +656,7 @@
> dev->name, base, irq);
>
> aup = dev->priv;
> + spin_lock_init(&aup->lock);
>
> /* Allocate the data buffers */
> /* Snooping works fine with eth on all au1xxx */
> @@ -766,7 +767,6 @@
> aup->tx_db_inuse[i] = pDB;
> }
>
> - spin_lock_init(&aup->lock);
> dev->base_addr = base;
> dev->irq = irq;
applied
parent reply other threads:[~2008-09-13 19:55 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <4886E059.9000106@alpha-bit.de>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48CC1AB4.6020200@pobox.com \
--to=jgarzik@pobox.com \
--cc=martin.gebert@alpha-bit.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).