From: Jeff Garzik <jeff@garzik.org>
To: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] cs89x0: fix warning release_irq label
Date: Sat, 13 Sep 2008 15:56:20 -0400 [thread overview]
Message-ID: <48CC1AE4.60205@garzik.org> (raw)
In-Reply-To: <20080825233736.e7a17376.yoichi_yuasa@tripeaks.co.jp>
Yoichi Yuasa wrote:
> release_irq label is only used when ALLOW_DMA is defined.
>
> drivers/net/cs89x0.c: In function 'net_open':
> drivers/net/cs89x0.c:1401: warning: label 'release_irq' defined but not used
>
> Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
>
> diff -pruN -X /home/yuasa/Memo/dontdiff linux-orig/drivers/net/cs89x0.c linux/drivers/net/cs89x0.c
> --- linux-orig/drivers/net/cs89x0.c 2008-08-07 13:14:59.904521743 +0900
> +++ linux/drivers/net/cs89x0.c 2008-08-07 16:11:31.469037245 +0900
> @@ -1397,9 +1397,7 @@ net_open(struct net_device *dev)
> release_dma:
> #if ALLOW_DMA
> free_dma(dev->dma);
> -#endif
> release_irq:
> -#if ALLOW_DMA
> release_dma_buff(lp);
> #endif
applied
prev parent reply other threads:[~2008-09-13 19:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-25 14:37 [PATCH] cs89x0: fix warning release_irq label Yoichi Yuasa
2008-09-13 19:56 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48CC1AE4.60205@garzik.org \
--to=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=yoichi_yuasa@tripeaks.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).