* [PATCH] cs89x0: fix warning release_irq label
@ 2008-08-25 14:37 Yoichi Yuasa
2008-09-13 19:56 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Yoichi Yuasa @ 2008-08-25 14:37 UTC (permalink / raw)
To: Jeff Garzik; +Cc: yoichi_yuasa, netdev
release_irq label is only used when ALLOW_DMA is defined.
drivers/net/cs89x0.c: In function 'net_open':
drivers/net/cs89x0.c:1401: warning: label 'release_irq' defined but not used
Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
diff -pruN -X /home/yuasa/Memo/dontdiff linux-orig/drivers/net/cs89x0.c linux/drivers/net/cs89x0.c
--- linux-orig/drivers/net/cs89x0.c 2008-08-07 13:14:59.904521743 +0900
+++ linux/drivers/net/cs89x0.c 2008-08-07 16:11:31.469037245 +0900
@@ -1397,9 +1397,7 @@ net_open(struct net_device *dev)
release_dma:
#if ALLOW_DMA
free_dma(dev->dma);
-#endif
release_irq:
-#if ALLOW_DMA
release_dma_buff(lp);
#endif
writereg(dev, PP_LineCTL, readreg(dev, PP_LineCTL) & ~(SERIAL_TX_ON | SERIAL_RX_ON));
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] cs89x0: fix warning release_irq label
2008-08-25 14:37 [PATCH] cs89x0: fix warning release_irq label Yoichi Yuasa
@ 2008-09-13 19:56 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-09-13 19:56 UTC (permalink / raw)
To: Yoichi Yuasa; +Cc: netdev
Yoichi Yuasa wrote:
> release_irq label is only used when ALLOW_DMA is defined.
>
> drivers/net/cs89x0.c: In function 'net_open':
> drivers/net/cs89x0.c:1401: warning: label 'release_irq' defined but not used
>
> Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
>
> diff -pruN -X /home/yuasa/Memo/dontdiff linux-orig/drivers/net/cs89x0.c linux/drivers/net/cs89x0.c
> --- linux-orig/drivers/net/cs89x0.c 2008-08-07 13:14:59.904521743 +0900
> +++ linux/drivers/net/cs89x0.c 2008-08-07 16:11:31.469037245 +0900
> @@ -1397,9 +1397,7 @@ net_open(struct net_device *dev)
> release_dma:
> #if ALLOW_DMA
> free_dma(dev->dma);
> -#endif
> release_irq:
> -#if ALLOW_DMA
> release_dma_buff(lp);
> #endif
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-09-13 19:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-25 14:37 [PATCH] cs89x0: fix warning release_irq label Yoichi Yuasa
2008-09-13 19:56 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).