From: Jeff Garzik <jeff@garzik.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
Alessandro Guido <alessandro.guido@gmail.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
pm list <linux-pm@lists.linux-foundation.org>
Subject: Re: [PATCH] e100: Use pci_pme_active to clear PME_Status and disable PME#
Date: Sat, 13 Sep 2008 16:15:56 -0400 [thread overview]
Message-ID: <48CC1F7C.7050908@garzik.org> (raw)
In-Reply-To: <200808080018.05887.rjw@sisk.pl>
Rafael J. Wysocki wrote:
> e100: Use pci_pme_active to clear PME_Status and disable PME#
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
>
> ---
> drivers/net/e100.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> Index: linux-2.6/drivers/net/e100.c
> ===================================================================
> --- linux-2.6.orig/drivers/net/e100.c
> +++ linux-2.6/drivers/net/e100.c
> @@ -2738,9 +2738,7 @@ static int __devinit e100_probe(struct p
> nic->flags |= wol_magic;
>
> /* ack any pending wake events, disable PME */
> - err = pci_enable_wake(pdev, 0, 0);
> - if (err)
> - DPRINTK(PROBE, ERR, "Error clearing wake event\n");
> + pci_pme_active(pdev, false);
Since I am rusty on my PCI... why is this needed?
next prev parent reply other threads:[~2008-09-13 20:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-05 15:30 "e100_probe: Error clearing wake event" when booting 2.6.27-rc1 Alessandro Guido
2008-08-05 20:03 ` Rafael J. Wysocki
2008-08-07 16:47 ` Jesse Barnes
2008-08-07 22:00 ` Rafael J. Wysocki
2008-08-07 22:14 ` [PATCH] PCI PM: Export pci_pme_active to drivers Rafael J. Wysocki
2008-08-07 22:18 ` [PATCH] e100: Use pci_pme_active to clear PME_Status and disable PME# Rafael J. Wysocki
2008-09-13 20:15 ` Jeff Garzik [this message]
2008-09-14 23:44 ` Rafael J. Wysocki
2008-08-07 22:34 ` [PATCH] PCI PM: Export pci_pme_active to drivers Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48CC1F7C.7050908@garzik.org \
--to=jeff@garzik.org \
--cc=alessandro.guido@gmail.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).