From: Simon Arlott <simon@fire.lp0.eu>
To: Jeff Garzik <jeff@garzik.org>
Cc: akpm@linux-foundation.org, netdev@vger.kernel.org,
aabdulla@nvidia.com, jgarzik@redhat.com,
ranma+kernel@tdiedrich.de
Subject: Re: [patch 10/12] forcedeth: add pci_enable_device() to nv_resume()
Date: Sun, 14 Sep 2008 13:40:53 +0100 [thread overview]
Message-ID: <48CD0655.6050809@simon.arlott.org.uk> (raw)
In-Reply-To: <48CC55FF.4050300@garzik.org>
On 14/09/08 01:08, Jeff Garzik wrote:
> akpm@linux-foundation.org wrote:
>> From: Simon Arlott <simon@fire.lp0.eu>
>>
>> My NIC stops working after resuming from standby, it's not receiving any
>> interrupts.
>>
>> Commit 25d90810ff49d2a63475776f24c74c6bb49b045f ([netdrvr] forcedeth:
>> reorder suspend/resume code) introduces pci_disable_device to nv_suspend,
>> but there's no corresponding pci_enable_device in nv_resume - so I added
>> one (copied from e1000). This results in interrupts being re-enabled
>> after suspend.
>>
>> However, the NIC (10de:0373) still doesn't work after resume.
>
> So... the NIC doesn't work after resume, even after your patch is applied?
It works after resume with MSI disabled.
--
Simon Arlott
prev parent reply other threads:[~2008-09-14 12:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-20 23:52 [patch 10/12] forcedeth: add pci_enable_device() to nv_resume() akpm
2008-09-14 0:08 ` Jeff Garzik
2008-09-14 12:40 ` Simon Arlott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48CD0655.6050809@simon.arlott.org.uk \
--to=simon@fire.lp0.eu \
--cc=aabdulla@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=jeff@garzik.org \
--cc=jgarzik@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=ranma+kernel@tdiedrich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).