* Re: linux-next: Tree for September 13 (3c509) [not found] <20080913162344.ab395285.sfr@canb.auug.org.au> @ 2008-09-14 21:17 ` Randy Dunlap 2008-09-15 14:11 ` Adrian Bunk 0 siblings, 1 reply; 5+ messages in thread From: Randy Dunlap @ 2008-09-14 21:17 UTC (permalink / raw) To: Stephen Rothwell; +Cc: linux-next, LKML, netdev drivers/net/3c509.c fails (CONFIG_PM=y) with: drivers/built-in.o:(.data+0x7dcc): undefined reference to `el3_resume' drivers/built-in.o:(.data+0x7e08): undefined reference to `el3_resume' It seems that this function does not exist in the source file. --- ~Randy Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA http://linuxplumbersconf.org/ ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for September 13 (3c509) 2008-09-14 21:17 ` linux-next: Tree for September 13 (3c509) Randy Dunlap @ 2008-09-15 14:11 ` Adrian Bunk 2008-09-15 14:27 ` Hannes Reinecke 0 siblings, 1 reply; 5+ messages in thread From: Adrian Bunk @ 2008-09-15 14:11 UTC (permalink / raw) To: Randy Dunlap, Hannes Reinecke, Kay Sievers, Greg Kroah-Hartman Cc: Stephen Rothwell, linux-next, LKML, netdev On Sun, Sep 14, 2008 at 02:17:57PM -0700, Randy Dunlap wrote: > drivers/net/3c509.c fails (CONFIG_PM=y) with: > > drivers/built-in.o:(.data+0x7dcc): undefined reference to `el3_resume' > drivers/built-in.o:(.data+0x7e08): undefined reference to `el3_resume' > > It seems that this function does not exist in the source file. It got removed by: commit 107aeb9753159da848f066b26557f0aaab900a90 Author: Hannes Reinecke <hare@suse.de> Date: Wed Sep 10 14:16:04 2008 +0200 Driver core: Use dev_get_drvdata() accessors Deprecated direct access to the ->driver_data field and use accessors throughout. Signed-off-by: Hannes Reinecke <hare@suse.de> Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for September 13 (3c509) 2008-09-15 14:11 ` Adrian Bunk @ 2008-09-15 14:27 ` Hannes Reinecke 2008-09-15 15:03 ` Randy Dunlap 0 siblings, 1 reply; 5+ messages in thread From: Hannes Reinecke @ 2008-09-15 14:27 UTC (permalink / raw) To: Adrian Bunk Cc: Randy Dunlap, Kay Sievers, Greg Kroah-Hartman, Stephen Rothwell, linux-next, LKML, netdev [-- Attachment #1: Type: text/plain, Size: 1076 bytes --] Hi Adrian, Adrian Bunk wrote: > On Sun, Sep 14, 2008 at 02:17:57PM -0700, Randy Dunlap wrote: >> drivers/net/3c509.c fails (CONFIG_PM=y) with: >> >> drivers/built-in.o:(.data+0x7dcc): undefined reference to `el3_resume' >> drivers/built-in.o:(.data+0x7e08): undefined reference to `el3_resume' >> >> It seems that this function does not exist in the source file. > > > It got removed by: > > > commit 107aeb9753159da848f066b26557f0aaab900a90 > Author: Hannes Reinecke <hare@suse.de> > Date: Wed Sep 10 14:16:04 2008 +0200 > > Driver core: Use dev_get_drvdata() accessors > > Deprecated direct access to the ->driver_data field and > use accessors throughout. > > Signed-off-by: Hannes Reinecke <hare@suse.de> > Cc: Kay Sievers <kay.sievers@vrfy.org> > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> > Sorry. Here it is again. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Markus Rex, HRB 16746 (AG Nürnberg) [-- Attachment #2: 3c509-readd-el3_resume --] [-- Type: text/plain, Size: 621 bytes --] Re-add el3_resume to 3c509 In commit 107aeb9753159da848f066b26557f0aaab900a90 el3_resume() from drivers/net/3c509.c accidentally got removed. Re-add it. Signed-off-by: Hannes Reinecke <hare@suse.de> diff --git a/drivers/net/3c509.c b/drivers/net/3c509.c index b33f7d9..6ace220 100644 --- a/drivers/net/3c509.c +++ b/drivers/net/3c509.c @@ -1493,6 +1493,15 @@ el3_common_resume(struct net_device *dev) return 0; } +static int +el3_resume(struct device *pdev) +{ + struct net_device *dev; + + dev = dev_get_drvdata(pdev); + return el3_common_resume(dev); +} + #endif /* CONFIG_PM */ module_param(debug,int, 0); ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for September 13 (3c509) 2008-09-15 14:27 ` Hannes Reinecke @ 2008-09-15 15:03 ` Randy Dunlap 2008-09-15 18:55 ` Greg KH 0 siblings, 1 reply; 5+ messages in thread From: Randy Dunlap @ 2008-09-15 15:03 UTC (permalink / raw) To: Hannes Reinecke Cc: Adrian Bunk, Kay Sievers, Greg Kroah-Hartman, Stephen Rothwell, linux-next, LKML, netdev On Mon, 15 Sep 2008 16:27:24 +0200 Hannes Reinecke wrote: > Hi Adrian, > > Adrian Bunk wrote: > > On Sun, Sep 14, 2008 at 02:17:57PM -0700, Randy Dunlap wrote: > >> drivers/net/3c509.c fails (CONFIG_PM=y) with: > >> > >> drivers/built-in.o:(.data+0x7dcc): undefined reference to `el3_resume' > >> drivers/built-in.o:(.data+0x7e08): undefined reference to `el3_resume' > >> > >> It seems that this function does not exist in the source file. > > > > > > It got removed by: > > > > > > commit 107aeb9753159da848f066b26557f0aaab900a90 > > Author: Hannes Reinecke <hare@suse.de> > > Date: Wed Sep 10 14:16:04 2008 +0200 > > > > Driver core: Use dev_get_drvdata() accessors > > > > Deprecated direct access to the ->driver_data field and > > use accessors throughout. > > > > Signed-off-by: Hannes Reinecke <hare@suse.de> > > Cc: Kay Sievers <kay.sievers@vrfy.org> > > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> > > > Sorry. Here it is again. Ack, that [attached] patch fixes the build. --- ~Randy Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA http://linuxplumbersconf.org/ ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for September 13 (3c509) 2008-09-15 15:03 ` Randy Dunlap @ 2008-09-15 18:55 ` Greg KH 0 siblings, 0 replies; 5+ messages in thread From: Greg KH @ 2008-09-15 18:55 UTC (permalink / raw) To: Randy Dunlap Cc: Hannes Reinecke, Adrian Bunk, Kay Sievers, Stephen Rothwell, linux-next, LKML, netdev On Mon, Sep 15, 2008 at 08:03:57AM -0700, Randy Dunlap wrote: > On Mon, 15 Sep 2008 16:27:24 +0200 Hannes Reinecke wrote: > > > Hi Adrian, > > > > Adrian Bunk wrote: > > > On Sun, Sep 14, 2008 at 02:17:57PM -0700, Randy Dunlap wrote: > > >> drivers/net/3c509.c fails (CONFIG_PM=y) with: > > >> > > >> drivers/built-in.o:(.data+0x7dcc): undefined reference to `el3_resume' > > >> drivers/built-in.o:(.data+0x7e08): undefined reference to `el3_resume' > > >> > > >> It seems that this function does not exist in the source file. > > > > > > > > > It got removed by: > > > > > > > > > commit 107aeb9753159da848f066b26557f0aaab900a90 > > > Author: Hannes Reinecke <hare@suse.de> > > > Date: Wed Sep 10 14:16:04 2008 +0200 > > > > > > Driver core: Use dev_get_drvdata() accessors > > > > > > Deprecated direct access to the ->driver_data field and > > > use accessors throughout. > > > > > > Signed-off-by: Hannes Reinecke <hare@suse.de> > > > Cc: Kay Sievers <kay.sievers@vrfy.org> > > > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> > > > > > Sorry. Here it is again. > > Ack, that [attached] patch fixes the build. Now merged in with Hannes's original patch. thanks, greg k-h ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-09-15 18:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20080913162344.ab395285.sfr@canb.auug.org.au>
2008-09-14 21:17 ` linux-next: Tree for September 13 (3c509) Randy Dunlap
2008-09-15 14:11 ` Adrian Bunk
2008-09-15 14:27 ` Hannes Reinecke
2008-09-15 15:03 ` Randy Dunlap
2008-09-15 18:55 ` Greg KH
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).