Re: [RFC PATCH v6 00/16] Labeled networking patches for 2.6.28

[Casey Schaufler <casey@schaufler-ca.com>]

Paul Moore wrote:
> On Tuesday 16 September 2008 8:55:48 am Paul Moore wrote:
>   
>> Another revision to the patchset to fix two issues, one trivial, the
>> other not so much.  The trivial fix was to add some locking around
>> the connection labeling operations, we're messing with the socket so
>> we should make sure we lock it like we do everywhere else.  The
>> second fix was to ensure that we sync up a stream socket's MSS value
>> when we add IP options to the socket. We were doing everything
>> correctly on the client side, but the server side was a bit of a
>> mess; I'm pretty happy with this fix as I think it actually makes the
>> code a bit cleaner in some respects and I believe actually shrinks
>> the size of the diff slightly (a good sign).
>>
>> A special thanks to Joe Nall and John Wiseman for helping debug the
>> MSS problem.
>>
>> I've updated both the git trees earlier today so hopefully the next
>> cut of the linux-next tree should have the latest bits.
>>
>>  * git://git.infradead.org/users/pcmoore/lblnet-2.6_testing
>>     
>
> I forgot to add, there is also a small fix to the 
> cipso_v4_sock_delattr() function so that it correctly removes the CIPSO 
> option and either adjust the option padding correctly or removes the 
> options struct entirely from the socket if it is no longer needed.
>
> Thanks to Casey Schaufler for finding this bug

Testing in progress. Thank you.