From: Jeff Garzik <jeff@garzik.org>
To: Ron Mercer <ron.mercer@qlogic.com>
Cc: NetDev <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/1] qlge: New Qlogic 10Gb Ethernet Driver single patch
Date: Thu, 18 Sep 2008 12:10:01 -0400 [thread overview]
Message-ID: <48D27D59.4020105@garzik.org> (raw)
In-Reply-To: <20080916203246.GA27264@susedev.qlogic.org>
Ron Mercer wrote:
>>From c041fd2a648cc2685b21cb7e722ba9fb05be114e Mon Sep 17 00:00:00 2001
> From: Ron Mercer <ron.mercer@qlogic.com>
> Date: Tue, 16 Sep 2008 12:17:52 -0700
> Subject: [PATCH 1/1] qlge: New Qlogic 10Gb Ethernet Driver.
>
>
> Signed-off-by: Ron Mercer <ron.mercer@qlogic.com>
> ---
> Documentation/networking/LICENSE.qlge | 46 +
> MAINTAINERS | 7 +
> drivers/net/Kconfig | 9 +
> drivers/net/Makefile | 1 +
> drivers/net/qlge/Makefile | 7 +
> drivers/net/qlge/qlge.h | 1593 +++++++++++++
> drivers/net/qlge/qlge_dbg.c | 858 +++++++
> drivers/net/qlge/qlge_ethtool.c | 415 ++++
> drivers/net/qlge/qlge_main.c | 3954 +++++++++++++++++++++++++++++++++
> drivers/net/qlge/qlge_mpi.c | 150 ++
> 10 files changed, 7040 insertions(+), 0 deletions(-)
> create mode 100644 Documentation/networking/LICENSE.qlge
> create mode 100644 drivers/net/qlge/Makefile
> create mode 100644 drivers/net/qlge/qlge.h
> create mode 100644 drivers/net/qlge/qlge_dbg.c
> create mode 100644 drivers/net/qlge/qlge_ethtool.c
> create mode 100644 drivers/net/qlge/qlge_main.c
> create mode 100644 drivers/net/qlge/qlge_mpi.c
applied, after fixing pci_dma_mapping_error() build breakage: you only
used one argument, when calling pci_dma_mapping_error(). I'm guessing
that (a) you did not build test this on multiple platforms, both 32-bit
and 64-bit, or (b) you are building against an older version of the kernel?
Either way, no big deal, I fixed it. But that's something to watch for
next time. Your patches should always successfully build, ideally.
parent reply other threads:[~2008-09-18 16:10 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20080916203246.GA27264@susedev.qlogic.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D27D59.4020105@garzik.org \
--to=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=ron.mercer@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).