From: Jeff Garzik <jeff@garzik.org>
To: akpm@linux-foundation.org
Cc: netdev@vger.kernel.org, chrisl@vmware.com, arvidjaar@mail.ru,
bruce.w.allan@intel.com, jeffrey.t.kirsher@intel.com,
jesse.brandeburg@intel.com, john.ronciak@intel.com,
peter.p.waskiewicz.jr@intel.com, pratap@vmware.com,
zach@vmware.com
Subject: Re: [patch for 2.6.27? 3/6] e1000: prevent corruption of EEPROM/NVM
Date: Thu, 18 Sep 2008 21:41:09 -0400 [thread overview]
Message-ID: <48D30335.1070908@garzik.org> (raw)
In-Reply-To: <200809052104.m85L46VE020352@imap1.linux-foundation.org>
akpm@linux-foundation.org wrote:
> From: Christopher Li <chrisl@vmware.com>
>
> Andrey reports e1000 corruption, and that a patch in vmware's ESX fixed
> it.
>
> The EEPROM corruption is triggered by concurrent access of the EEPROM
> read/write. Putting a lock around it solve the problem.
>
> [akpm@linux-foundation.org: use DEFINE_SPINLOCK to avoid confusing lockdep]
> Signed-off-by: Christopher Li <chrisl@vmware.com>
> Reported-by: Andrey Borzenkov <arvidjaar@mail.ru>
> Cc: Zach Amsden <zach@vmware.com>
> Cc: Pratap Subrahmanyam <pratap@vmware.com>
> Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Cc: Bruce Allan <bruce.w.allan@intel.com>
> Cc: PJ Waskiewicz <peter.p.waskiewicz.jr@intel.com>
> Cc: John Ronciak <john.ronciak@intel.com>
> Cc: Jeff Garzik <jeff@garzik.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> drivers/net/e1000/e1000_hw.c | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
No further reply from Intel to my ping, and this regression needs to be
addressed, so, applied.
next prev parent reply other threads:[~2008-09-19 1:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-05 21:04 [patch for 2.6.27? 3/6] e1000: prevent corruption of EEPROM/NVM akpm
2008-09-19 1:41 ` Jeff Garzik [this message]
2008-09-19 16:20 ` Brandeburg, Jesse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D30335.1070908@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=arvidjaar@mail.ru \
--cc=bruce.w.allan@intel.com \
--cc=chrisl@vmware.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=pratap@vmware.com \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).