From: Jeff Garzik <jeff@garzik.org>
To: akpm@linux-foundation.org
Cc: netdev@vger.kernel.org, jie.yang@atheros.com
Subject: Re: [patch 16/21] atl1e: remove the unneeded (struct atl1e_adapter *)
Date: Wed, 24 Sep 2008 20:49:52 -0400 [thread overview]
Message-ID: <48DAE030.5050003@garzik.org> (raw)
In-Reply-To: <200809222152.m8MLqPYL031984@imap1.linux-foundation.org>
akpm@linux-foundation.org wrote:
> From: Jie Yang <jie.yang@atheros.com>
>
> Remove the unneeded (struct atl1e_adapter *) casts, for hw->adapter
> already has type atl1e_adapter *.
>
> Signed-off-by: Jie Yang <jie.yang@atheros.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> drivers/net/atl1e/atl1e_hw.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff -puN drivers/net/atl1e/atl1e_hw.c~atl1e-remove-the-unneeded-struct-atl1e_adapter drivers/net/atl1e/atl1e_hw.c
> --- a/drivers/net/atl1e/atl1e_hw.c~atl1e-remove-the-unneeded-struct-atl1e_adapter
> +++ a/drivers/net/atl1e/atl1e_hw.c
> @@ -397,7 +397,7 @@ static int atl1e_phy_setup_autoneg_adv(s
> */
> int atl1e_phy_commit(struct atl1e_hw *hw)
> {
> - struct atl1e_adapter *adapter = (struct atl1e_adapter *)hw->adapter;
> + struct atl1e_adapter *adapter = hw->adapter;
> struct pci_dev *pdev = adapter->pdev;
> int ret_val;
> u16 phy_data;
> @@ -431,7 +431,7 @@ int atl1e_phy_commit(struct atl1e_hw *hw
>
> int atl1e_phy_init(struct atl1e_hw *hw)
> {
> - struct atl1e_adapter *adapter = (struct atl1e_adapter *)hw->adapter;
> + struct atl1e_adapter *adapter = hw->adapter;
> struct pci_dev *pdev = adapter->pdev;
> s32 ret_val;
> u16 phy_val;
> @@ -525,7 +525,7 @@ int atl1e_phy_init(struct atl1e_hw *hw)
> */
> int atl1e_reset_hw(struct atl1e_hw *hw)
> {
> - struct atl1e_adapter *adapter = (struct atl1e_adapter *)hw->adapter;
> + struct atl1e_adapter *adapter = hw->adapter;
> struct pci_dev *pdev = adapter->pdev;
>
> u32 idle_status_data = 0;
applied
prev parent reply other threads:[~2008-09-25 0:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-22 21:52 [patch 16/21] atl1e: remove the unneeded (struct atl1e_adapter *) akpm
2008-09-25 0:49 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48DAE030.5050003@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=jie.yang@atheros.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).