netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Florian Fainelli <florian@openwrt.org>
Cc: Francois Romieu <romieu@fr.zoreil.com>, netdev@vger.kernel.org
Subject: Re: [PATCH] r6040: fix wrong assignment in r6040_free_txbufs
Date: Wed, 24 Sep 2008 20:52:01 -0400	[thread overview]
Message-ID: <48DAE0B1.4000706@garzik.org> (raw)
In-Reply-To: <200809242116.40855.florian@openwrt.org>

Florian Fainelli wrote:
> Hello Jeff, Francois,
> 
> This is 2.6.27 material but should be applied to your -next branch as well. Thank you.
> --
> From: Florian Fainelli <florian@openwrt.org>
> Subject: [PATCH] r6040: fix wrong assignment in r6040_free_txbufs
> 
> This patch fixes a wrong assignment in r6040_free_txbufs
> on a receive skb pointer while we should actually do this
> on the transmit skb pointer.
> 
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
> ---
> diff --git a/drivers/net/r6040.c b/drivers/net/r6040.c
> index 396f0e4..5aff7c8 100644
> --- a/drivers/net/r6040.c
> +++ b/drivers/net/r6040.c
> @@ -261,7 +261,7 @@ static void r6040_free_txbufs(struct net_device *dev)
>  				le32_to_cpu(lp->tx_insert_ptr->buf),
>  				MAX_BUF_SIZE, PCI_DMA_TODEVICE);
>  			dev_kfree_skb(lp->tx_insert_ptr->skb_ptr);
> -			lp->rx_insert_ptr->skb_ptr = NULL;
> +			lp->tx_insert_ptr->skb_ptr = NULL;
>  		}
>  		lp->tx_insert_ptr = lp->tx_insert_ptr->vndescp;
>  	}

applied



      reply	other threads:[~2008-09-25  0:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-24 19:16 [PATCH] r6040: fix wrong assignment in r6040_free_txbufs Florian Fainelli
2008-09-25  0:52 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48DAE0B1.4000706@garzik.org \
    --to=jeff@garzik.org \
    --cc=florian@openwrt.org \
    --cc=netdev@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).