* [PATCH] r6040: fix wrong assignment in r6040_free_txbufs
@ 2008-09-24 19:16 Florian Fainelli
2008-09-25 0:52 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Florian Fainelli @ 2008-09-24 19:16 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Francois Romieu, netdev
Hello Jeff, Francois,
This is 2.6.27 material but should be applied to your -next branch as well. Thank you.
--
From: Florian Fainelli <florian@openwrt.org>
Subject: [PATCH] r6040: fix wrong assignment in r6040_free_txbufs
This patch fixes a wrong assignment in r6040_free_txbufs
on a receive skb pointer while we should actually do this
on the transmit skb pointer.
Signed-off-by: Florian Fainelli <florian@openwrt.org>
---
diff --git a/drivers/net/r6040.c b/drivers/net/r6040.c
index 396f0e4..5aff7c8 100644
--- a/drivers/net/r6040.c
+++ b/drivers/net/r6040.c
@@ -261,7 +261,7 @@ static void r6040_free_txbufs(struct net_device *dev)
le32_to_cpu(lp->tx_insert_ptr->buf),
MAX_BUF_SIZE, PCI_DMA_TODEVICE);
dev_kfree_skb(lp->tx_insert_ptr->skb_ptr);
- lp->rx_insert_ptr->skb_ptr = NULL;
+ lp->tx_insert_ptr->skb_ptr = NULL;
}
lp->tx_insert_ptr = lp->tx_insert_ptr->vndescp;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] r6040: fix wrong assignment in r6040_free_txbufs
2008-09-24 19:16 [PATCH] r6040: fix wrong assignment in r6040_free_txbufs Florian Fainelli
@ 2008-09-25 0:52 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-09-25 0:52 UTC (permalink / raw)
To: Florian Fainelli; +Cc: Francois Romieu, netdev
Florian Fainelli wrote:
> Hello Jeff, Francois,
>
> This is 2.6.27 material but should be applied to your -next branch as well. Thank you.
> --
> From: Florian Fainelli <florian@openwrt.org>
> Subject: [PATCH] r6040: fix wrong assignment in r6040_free_txbufs
>
> This patch fixes a wrong assignment in r6040_free_txbufs
> on a receive skb pointer while we should actually do this
> on the transmit skb pointer.
>
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
> ---
> diff --git a/drivers/net/r6040.c b/drivers/net/r6040.c
> index 396f0e4..5aff7c8 100644
> --- a/drivers/net/r6040.c
> +++ b/drivers/net/r6040.c
> @@ -261,7 +261,7 @@ static void r6040_free_txbufs(struct net_device *dev)
> le32_to_cpu(lp->tx_insert_ptr->buf),
> MAX_BUF_SIZE, PCI_DMA_TODEVICE);
> dev_kfree_skb(lp->tx_insert_ptr->skb_ptr);
> - lp->rx_insert_ptr->skb_ptr = NULL;
> + lp->tx_insert_ptr->skb_ptr = NULL;
> }
> lp->tx_insert_ptr = lp->tx_insert_ptr->vndescp;
> }
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-09-25 0:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-24 19:16 [PATCH] r6040: fix wrong assignment in r6040_free_txbufs Florian Fainelli
2008-09-25 0:52 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).