From: Jeff Garzik <jeff@garzik.org>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Jeff Garzik <jgarzik@redhat.com>,
Weiwei Wang <weiwei.wang@windriver.com>,
linux-mips@linux-mips.org, netdev@vger.kernel.org
Subject: Re: [PATCH] convert sbmac tx to spin_lock_irqsave to prevent early IRQ enable
Date: Thu, 25 Sep 2008 15:33:40 -0400 [thread overview]
Message-ID: <48DBE794.9010309@garzik.org> (raw)
In-Reply-To: <20080920201839.GA27700@linux-mips.org>
Ralf Baechle wrote:
> On Wed, Sep 17, 2008 at 07:40:51AM -0400, Jeff Garzik wrote:
>
>> On Wed, Sep 17, 2008 at 10:25:37AM +0800, Weiwei Wang wrote:
>>> Netpoll will call the interrupt handler with interrupts
>>> disabled when using kgdboe, so spin_lock_irqsave() should
>>> be used instead of spin_lock_irq() to prevent interrupts
>>> from being incorrectly enabled.
>>>
>>> Signed-off-by: Weiwei Wang <weiwei.wang@windriver.com>
>>> ---
>>> drivers/net/sb1250-mac.c | 12 +++++++-----
>>> 1 files changed, 7 insertions(+), 5 deletions(-)
>> Please send to jeff@garzik.org or jgarzik@pobox.com.
>
> Jeff - I haven't looked at kgdboe but if he's right half of drivers/net
> will need to be fixed ...
Oh indeed. I mainly do it on a case-by-case basis where people care. I
overall think its a bogus change that deserves pushback, but that
involves non-networking layers. In the end, case-by-case application
seemed to win.
Jeff
next prev parent reply other threads:[~2008-09-25 19:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <6781da3918e3c34d23e5f7e9cf777ab463a17d5e.1221613284.git.weiwei.wang@windriver.com>
[not found] ` <20080917114051.GA30734@shell.devel.redhat.com>
2008-09-20 20:18 ` [PATCH] convert sbmac tx to spin_lock_irqsave to prevent early IRQ enable Ralf Baechle
2008-09-25 19:33 ` Jeff Garzik [this message]
2008-09-25 23:49 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48DBE794.9010309@garzik.org \
--to=jeff@garzik.org \
--cc=jgarzik@redhat.com \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=weiwei.wang@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).