From: Arjan van de Ven <arjan@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Jesse Brandeburg <jesse.brandeburg@gmail.com>,
Jiri Kosina <jkosina@suse.cz>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
David Miller <davem@davemloft.net>,
jesse.brandeburg@intel.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, kkeil@suse.de, agospoda@redhat.com,
david.graham@intel.com, bruce.w.allan@intel.com,
john.ronciak@intel.com, chris.jones@canonical.com,
tim.gardner@canonical.com, airlied@gmail.com,
Olaf Kirch <okir@suse.de>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [RFC PATCH 02/12] On Tue, 23 Sep 2008, David Miller wrote:
Date: Sun, 05 Oct 2008 08:05:09 -0700 [thread overview]
Message-ID: <48E8D7A5.7060508@linux.intel.com> (raw)
In-Reply-To: <alpine.LFD.2.00.0810050959420.3398@apollo>
Thomas Gleixner wrote:
> On Sat, 4 Oct 2008, Jesse Brandeburg wrote:
>>> Exactly. The access to a ro region results in a fault. I have nowhere
>>> seen that trigger, but I can reproduce the trylock() WARN_ON, which
>>> confirms that there is concurrent access to the NVRAM registers. The
>>> backtrace pattern is similar to the one you have seen.
>> are you still getting WARN_ON *with* all the mutex based fixes already applied?
>
> The WARN_ON triggers with current mainline. Is there any fixlet in
> Linus tree missing ?
>
>> with the mutex patches in place (without protection patch) we are
>> still reproducing the issue, until we apply the set_memory_ro patch.
>
> That does not make sense to me. If the memory_ro patch is providing
> _real_ protection then you _must_ run into an access violation. If not,
> then the patch just papers over the real problem in some mysterious
> way.
>
not if the bad code is doing copy_to_user .... (or similar)
next prev parent reply other threads:[~2008-10-05 15:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080930030825.22950.18891.stgit@jbrandeb-bw.jf.intel.com>
[not found] ` <200810021523.45884.jbarnes@virtuousgeek.org>
[not found] ` <20081003.134634.240211201.davem@davemloft.net>
[not found] ` <200810031429.22598.jbarnes@virtuousgeek.org>
[not found] ` <alpine.LNX.1.10.0810032338140.26779@jikos.suse.cz>
[not found] ` <4807377b0810031628x43f79eferdbb9c9c264a5816e@mail.gmail.com>
2008-10-03 23:30 ` [RFC PATCH 02/12] On Tue, 23 Sep 2008, David Miller wrote: Jesse Brandeburg
[not found] ` <alpine.LNX.1.10.0810041219130.26779@jikos.suse.cz>
[not found] ` <alpine.LFD.2.00.0810041236250.4404@apollo>
2008-10-05 1:24 ` Jesse Brandeburg
2008-10-05 8:51 ` Thomas Gleixner
2008-10-05 15:05 ` Arjan van de Ven [this message]
2008-10-05 15:55 ` Thomas Gleixner
2008-10-05 16:02 ` Arjan van de Ven
2008-10-05 16:16 ` Thomas Gleixner
2008-10-05 17:01 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48E8D7A5.7060508@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=agospoda@redhat.com \
--cc=airlied@gmail.com \
--cc=bruce.w.allan@intel.com \
--cc=chris.jones@canonical.com \
--cc=davem@davemloft.net \
--cc=david.graham@intel.com \
--cc=jbarnes@virtuousgeek.org \
--cc=jesse.brandeburg@gmail.com \
--cc=jesse.brandeburg@intel.com \
--cc=jkosina@suse.cz \
--cc=john.ronciak@intel.com \
--cc=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=okir@suse.de \
--cc=tglx@linutronix.de \
--cc=tim.gardner@canonical.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).