netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Martin Devera <devik@cdi.cz>
To: Simon Horman <horms@verge.net.au>
Cc: Jarek Poplawski <jarkao2@gmail.com>,
	Patrick McHardy <kaber@trash.net>,
	netdev@vger.kernel.org, David Miller <davem@davemloft.net>
Subject: Re: Possible regression in HTB
Date: Thu, 09 Oct 2008 08:22:49 +0200	[thread overview]
Message-ID: <48EDA339.3040706@cdi.cz> (raw)
In-Reply-To: <20081009010957.GB6342@verge.net.au>

 >>
 >> Simon, can you try to these things (separately):
 >> a/ increase quantum to the first class (say 10x)
 >
 > Hi Martin,
 >
 > Do you mean increase r2q ? If so, here are some results

no, no, add rather ... "quantum 50000" to the first class only
r2q affects computation for all classes

 >> b/ set ceil=rate on all three classes
 >
 > This seems pretty close to the expected/ideal result.
 >
 > 10194: 496575074bits/s 496Mbits/s
 > 10197:  96969861bits/s  96Mbits/s
 > 10196:  96973002bits/s  96Mbits/s
 > -----------------------------------
 > total: 690517938bits/s 690Mbits/s
 >

Hmm, it seems that problem is with drr loop or borrowing,
rate computation seems to work ok even in this corner case.

In any case from your other test follows that when NIC
throttles then HTB can't arrive at correct rates - I feel
this as HTB bug and add it to my (very long) todo list...

thanks, Martin

  reply	other threads:[~2008-10-09  6:22 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-07  1:15 Possible regression in HTB Simon Horman
2008-10-07  4:51 ` Simon Horman
2008-10-07  7:44   ` Jarek Poplawski
2008-10-07 12:03     ` Patrick McHardy
2008-10-08  0:09     ` Simon Horman
2008-10-08  6:37       ` Jarek Poplawski
2008-10-08  7:22         ` Simon Horman
2008-10-08  7:53           ` Jarek Poplawski
2008-10-07 12:20   ` Jarek Poplawski
2008-10-07 12:48     ` Patrick McHardy
2008-10-07 22:00       ` Jarek Poplawski
2008-10-08  0:21         ` Simon Horman
2008-10-08  0:31           ` Patrick McHardy
2008-10-08  0:40             ` Patrick McHardy
2008-10-08  7:34               ` Martin Devera
2008-10-08  8:53                 ` Jarek Poplawski
2008-10-08 10:47                   ` Martin Devera
2008-10-08 12:04                     ` Jarek Poplawski
2008-10-09  1:09                     ` Simon Horman
2008-10-09  6:22                       ` Martin Devera [this message]
2008-10-09  9:56                         ` Jarek Poplawski
2008-10-09 10:14                           ` Jarek Poplawski
2008-10-09 10:52                           ` Martin Devera
2008-10-09 11:04                             ` Jarek Poplawski
2008-10-09 11:11                         ` Simon Horman
2008-10-09 11:22                           ` Martin Devera
2008-10-08  6:55             ` Jarek Poplawski
2008-10-08  7:06               ` Denys Fedoryshchenko
2008-10-08  7:46                 ` [PATCH] " Jarek Poplawski
2008-10-08 18:36                   ` David Miller
2008-10-08  7:22               ` Simon Horman
2008-10-08  8:03                 ` Jarek Poplawski
2008-10-09  0:54                   ` Simon Horman
2008-10-09  6:21                     ` Jarek Poplawski
2008-10-09  6:53                       ` Martin Devera
2008-10-09 11:18                       ` Simon Horman
2008-10-09 11:58                         ` Patrick McHardy
2008-10-09 12:36                         ` Jarek Poplawski
2008-10-10  6:59         ` Jarek Poplawski
2008-10-10  8:57           ` Jarek Poplawski
2008-10-10 12:12             ` Jarek Poplawski
2008-10-08  0:10     ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48EDA339.3040706@cdi.cz \
    --to=devik@cdi.cz \
    --cc=davem@davemloft.net \
    --cc=horms@verge.net.au \
    --cc=jarkao2@gmail.com \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).