* Re: myri10ge: add multiqueue TX
@ 2008-10-08 23:19 David Miller
2008-10-09 11:51 ` Brice Goglin
0 siblings, 1 reply; 2+ messages in thread
From: David Miller @ 2008-10-08 23:19 UTC (permalink / raw)
To: brice; +Cc: netdev
Applied to net-next-2.6 after removing the bogus references to the
non-existing CONFIG_NETDEVICES_MULTIQUEUE and NETIF_F_MULTI_QUEUE.
I do have a question about this patch, why in the world do you
need to modulus the queue number in ->hard_start_xmit() when
the core is going to do that for you modulus ->real_num_tx_queues?
If it's unnecessary, remove it please, thanks.
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: myri10ge: add multiqueue TX
2008-10-08 23:19 myri10ge: add multiqueue TX David Miller
@ 2008-10-09 11:51 ` Brice Goglin
0 siblings, 0 replies; 2+ messages in thread
From: Brice Goglin @ 2008-10-09 11:51 UTC (permalink / raw)
To: David Miller; +Cc: netdev
David Miller wrote:
> Applied to net-next-2.6 after removing the bogus references to the
> non-existing CONFIG_NETDEVICES_MULTIQUEUE and NETIF_F_MULTI_QUEUE.
>
> I do have a question about this patch, why in the world do you
> need to modulus the queue number in ->hard_start_xmit() when
> the core is going to do that for you modulus ->real_num_tx_queues?
>
Right, it's probably over-paranoid. We'll check things in depth and
probably remove it soon.
Brice
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-09 11:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-08 23:19 myri10ge: add multiqueue TX David Miller
2008-10-09 11:51 ` Brice Goglin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).