netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] myri10ge: remove over-paranoid queue number modulus
@ 2008-10-09 14:10 Brice Goglin
  2008-10-09 21:31 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Brice Goglin @ 2008-10-09 14:10 UTC (permalink / raw)
  To: Jeff Garzik, David S. Miller; +Cc: netdev

No need to modulus the queue number in ->hard_start_xmit() since the
core is going to do that for you modulus ->real_num_tx_queues.

Signed-off-by: Brice Goglin <brice@myri.com>

diff --git a/drivers/net/myri10ge/myri10ge.c b/drivers/net/myri10ge/myri10ge.c
index ab7755a..8cec6f3 100644
--- a/drivers/net/myri10ge/myri10ge.c
+++ b/drivers/net/myri10ge/myri10ge.c
@@ -2643,8 +2643,6 @@ static int myri10ge_xmit(struct sk_buff *skb, struct net_device *dev)
 	u8 flags, odd_flag;
 
 	queue = skb_get_queue_mapping(skb);
-	queue &= (mgp->num_slices - 1);
-
 	ss = &mgp->ss[queue];
 	netdev_queue = netdev_get_tx_queue(mgp->dev, queue);
 	tx = &ss->tx;



^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-10-09 21:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-09 14:10 [PATCH net-next] myri10ge: remove over-paranoid queue number modulus Brice Goglin
2008-10-09 21:31 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).