From: Patrick McHardy <kaber@trash.net>
To: "Brandeburg, Jesse" <jesse.brandeburg@intel.com>
Cc: Linux Netdev List <netdev@vger.kernel.org>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"Allan, Bruce W" <bruce.w.allan@intel.com>,
"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>,
"Ronciak, John" <john.ronciak@intel.com>,
e1000-devel@lists.sourceforge.net
Subject: Re: [PATCH RFC]: e1000: allow VLAN devices to use TSO and CSUM offload
Date: Sat, 11 Oct 2008 16:35:50 +0200 [thread overview]
Message-ID: <48F0B9C6.3030905@trash.net> (raw)
In-Reply-To: <36D9DB17C6DE9E40B059440DB8D95F5206672441@orsmsx418.amr.corp.intel.com>
Brandeburg, Jesse wrote:
>> These parts should all work (at least as advertised in the software
>> reference manual available at
>>
> http://superb-east.dl.sourceforge.net/sourceforge/e1000/OpenSDM_8254x-37
> .pdf)
>> with the exception of 82544 GC/EI
>>
>> So as it stands your patch will not work on some hardware. Also,
>> would we need to hook the ethtool methods such that if a user
>> disables TSO it will disable vlan_features(TSO) as well?
>
> Oh, and the 82542 and 82543 based parts don't do this either, they
> aren't covered by the manual above.
Thanks for the pointer (and for pushing the patch already).
prev parent reply other threads:[~2008-10-11 14:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-16 10:05 [PATCH RFC]: e1000: allow VLAN devices to use TSO and CSUM offload Patrick McHardy
2008-10-10 14:39 ` Patrick McHardy
2008-10-10 17:48 ` Brandeburg, Jesse
2008-10-10 17:59 ` Ben Hutchings
2008-10-10 19:09 ` David Miller
2008-10-10 22:01 ` Brandeburg, Jesse
2008-10-10 22:11 ` David Miller
2008-10-10 17:50 ` Brandeburg, Jesse
2008-10-11 14:35 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48F0B9C6.3030905@trash.net \
--to=kaber@trash.net \
--cc=bruce.w.allan@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).