From: Ben Greear <greearb@candelatech.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Patrick McHardy <kaber@trash.net>,
Arkadiusz Miskiewicz <arekm@maven.pl>,
Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [IPROUTE]: Fix up "ip link" help text
Date: Mon, 13 Oct 2008 09:36:06 -0700 [thread overview]
Message-ID: <48F378F6.40301@candelatech.com> (raw)
In-Reply-To: <20081013072129.2564130f@extreme>
Stephen Hemminger wrote:
> On Tue, 07 Oct 2008 23:02:17 +0200
> Patrick McHardy <kaber@trash.net> wrote:
>
>
>> Arkadiusz Miskiewicz wrote:
>>
>>> Runtime dependand help doesn't look sane. Help should always show all possible
>>> options/command while trying to use unsupported option should display error
>>> message.
>>>
>>>
>> That makes sense. But don't complain to me about the quality
>> of the error messages afterwards please :)
>>
>>
>>
>
> I applied a variant of Patrick's original patch. I added text for delete, and
> avoided some code movement. The help text should only show what is supported
> otherwise there will be user complaints.
>
I personally dislike that. I think the tool show should everything that
it *could* do assuming
proper kernel, etc. Then, if it turns out the current running kernel
can't do that, it could just
give an error: "This feature not supported in your current kernel. See
[url] for info on when
features were added to the kernel."
That way, the user can see all the possible goodness out there, and
perhaps be inclined to upgrade
to a later kernel if that gives them a feature they'd like.
Thanks,
Ben
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2008-10-13 16:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-07 15:17 [IPROUTE]: Fix up "ip link" help text Patrick McHardy
[not found] ` <200810072206.03062.arekm@maven.pl>
2008-10-07 21:02 ` Patrick McHardy
2008-10-07 21:18 ` Stephen Hemminger
2008-10-13 14:21 ` Stephen Hemminger
2008-10-13 16:36 ` Ben Greear [this message]
[not found] ` <200810131917.00864.arekm@maven.pl>
2008-10-13 18:07 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48F378F6.40301@candelatech.com \
--to=greearb@candelatech.com \
--cc=arekm@maven.pl \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).