netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Snook <csnook@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: afleming@gmail.com, afleming@freescale.com, netdev@vger.kernel.org
Subject: Re: [PATCH] Change S390 anti-dependency to CONFIG_GENERIC_HARDIRQS dependency
Date: Tue, 14 Oct 2008 19:43:05 -0400	[thread overview]
Message-ID: <48F52E89.9050104@redhat.com> (raw)
In-Reply-To: <20081014.163359.110730186.davem@davemloft.net>

David Miller wrote:
> From: "Andy Fleming" <afleming@gmail.com>
> Date: Tue, 14 Oct 2008 18:21:44 -0500
> 
>> Argh.  From what I could see, we have request_irq, free_irq,
>> disable_irq, enable_irq, and disable_irq_nosync.  For the PHYLIB, it
>> shouldn't be difficult to modify things so that it doesn't compile in
>> interrupt support if the system doesn't support them.  Shouldn't, that
>> is, if there's some config option that tells me whether those
>> functions exist.
> 
> I think this whole situation with s390 is rediculious.
> 
> If s390 is weird and lacks these fundamental things, that's fine.
> What isn't fine is how we're handling this.
> 
> No code should care or even be aware of this.
> 
> S390 should simply provide a set of dummy DMA and interrupt interface
> stubs that always fail and return an error value.
> 
> Then we can get rid of this S390 Kconfig stuff which has been spewed
> all over the place.

"depends on PCI" has always worked for me.  Any reason we can't use that 
here?

-- Chris

  reply	other threads:[~2008-10-14 23:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-14 22:28 [PATCH] Change S390 anti-dependency to CONFIG_GENERIC_HARDIRQS dependency Andy Fleming
2008-10-14 22:44 ` David Miller
2008-10-14 23:21   ` Andy Fleming
2008-10-14 23:33     ` David Miller
2008-10-14 23:43       ` Chris Snook [this message]
2008-10-14 23:52         ` David Miller
2008-10-15  0:07           ` Chris Snook
2008-10-15  5:16             ` David Miller
2008-10-15 16:48               ` Chris Snook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48F52E89.9050104@redhat.com \
    --to=csnook@redhat.com \
    --cc=afleming@freescale.com \
    --cc=afleming@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).